Cmnt: [SRU][J:linux-bluefield][Pull Request] mlxbf_bootctl: need to replace SAUCE patches with upstream commits

[David Thompson]

> -----Original Message-----
> From: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>
> Sent: Thursday, September 14, 2023 10:54 AM
> To: David Thompson <davthompson at nvidia.com>
> Cc: Ubuntu Kernel Team <kernel-team at lists.ubuntu.com>; Liming Sun
> <limings at nvidia.com>; Khalil Blaiech <kblaiech at nvidia.com>; Asmaa Mnebhi
> <asmaa at nvidia.com>
> Subject: Cmnt: [SRU][J:linux-bluefield][Pull Request] mlxbf_bootctl: need to
> replace SAUCE patches with upstream commits
> 
> Hi David,
> 
> On Thu, Aug 31, 2023 at 5:27 PM David Thompson <davthompson at nvidia.com>
> wrote:
> >
> > The Boot Control driver ("mlxbf_bootctl") in the Jammy repo contains
> > SAUCE patches for various features and bug fixes. This same
> > functionality is contained in upstream commits and Jammy repo should utilize
> them.
> >
> > This pull request reverts 4 SAUCE commits, replacing them with 6
> > upstream commits. There is still one SAUCE patch for this driver, as
> > this code change has not been upstreamed yet.
> >
> > BugLink: https://bugs.launchpad.net/bugs/2033551
> >
> > Testing
> > - Boot BF2/BF3 platform, verify no new errors
> > - Program MFG fields via "bfcfg" tool:
> >    1) With current image, use 'bfcfg -d' to display current values
> >    2) Reboot, stopping at UEFI menu, trigger 'Reset MFG Info'
> >    3) With new image, use 'bfcfg' to push new or same MFG fields
> >    4) Verify that the MFG fields are programmed properly via 'bfcfg -d'
> >    5) Repeat process to replace proper MFG fields
> > - Display BlueField boot log
> >    1) cd /sys/bus/platform/devices/MLNXBF04:00
> >    2) cat rsh_log
> >    3) Should see boot log entries relevant to last boot
> >
> > The pull request page can be found at:
> >
> > https://code.launchpad.net/~dthompso-98/ubuntu/+source/linux-bluefield
> > /+git/linux-bluefield/+merge/450360
> >
> > Git repo can be found at:
> >
> > git://git.launchpad.net/~dthompso-98/ubuntu/+source/linux-bluefield/+g
> > it/jammy mlxbf_bootctl
> 
> There is no mlxbf_bootctl branch there, the correct link seems to be:
> 
> git://git.launchpad.net/~dthompso-98/ubuntu/+source/linux-bluefield
> mlxbf_bootctl
> 
> Also the git repo is sufficient, there is no need for a merge request.
> 

Thanks for pointing this out, will fix in pull request v2.

> > for you to fetch starting from commit
> 1d8d5ce3c1fd55a49df7af139877e35ccd368e2d
> >   "UBUNTU: Ubuntu-bluefield-5.15.0-1022.24"
> >
> > Signed-off-by: David Thompson <davthompson at nvidia.com>
> >
> > Asmaa Mnebhi (2):
> >   mlxbf-bootctl: Support the large icmc write/read
> >   mlxbf-bootctl: Support setting the ARM boot state to "OS up"
> >
> > David Thompson (6):
> >   Revert "UBUNTU: SAUCE: mlxbf-bootctl: Fix kernel panic due to buffer
> >     overflow"
> >   Revert "UBUNTU: SAUCE: mlxbf-bootctl: support SMC call for setting ARM
> >     boot state"
> >   Revert "UBUNTU: SAUCE: mlx-bootctl: support icm carveout eeprom region
> >     read/write"
> >   Revert "UBUNTU: SAUCE: platform/mellanox: Updates to mlxbf-bootctl"
> 
> Please add your Signed-off-by: line to the revert patches.
> 

Sure, will add the SOB lines in pull request v2.

> >   mlxbf-bootctl: Support sysfs entries for MFG fields
> >   UBUNTU: SAUCE: mlxbf_bootctl: add support for reading BlueField boot
> >     log
> 
> The above patch seems to introduce some "whitespace damages", while not a
> major issue it would be the best to fix it.
>

Thanks for pointing this out, will fix in pull request v2.
 
> --
> Best regards,
> Bartlomiej
> 
> > Khalil Blaiech (1):
> >   platform/mellanox: add firmware reset support
> >
> > Liming Sun (2):
> >   mlxbf-bootctl: Add sysfs file for BlueField boot fifo
> >   mlxbf-bootctl: Add sysfs file for BlueField boot log
> >
> >  .../testing/sysfs-platform-mellanox-bootctl   |   82 +
> >  drivers/platform/mellanox/mlxbf-bootctl.c     | 1789 ++++++++---------
> >  drivers/platform/mellanox/mlxbf-bootctl.h     |   97 +-
> >  3 files changed, 1024 insertions(+), 944 deletions(-)
> >