ACK/Cmnt: [SRU][J/L/M:linux-meta-<many>][PATCH 0/1] linux-tools-<flavor> should provide linux-tools (LP: #2039437)

[Stefan Bader]

On 25.10.23 12:20, Juerg Haefliger wrote:
> On Thu, 19 Oct 2023 09:57:51 +0200
> Stefan Bader <stefan.bader at canonical.com> wrote:
> 
>> On 17.10.23 16:22, Juerg Haefliger wrote:
>>> [Impact]
>>>
>>> Missing 'Provides: linux-tools', results in:
>>>
>>> $ sudo apt install linux-tools
>>> Reading package lists... Done
>>> Building dependency tree... Done
>>> Reading state information... Done
>>> Package linux-tools is a virtual package provided by:
>>>     linux-tools-virtual-hwe-22.04-edge 6.5.0.9.11
>>>     linux-tools-virtual-hwe-22.04 6.5.0.9.11
>>>     linux-tools-virtual 6.5.0.9.11
>>>     linux-tools-generic-hwe-22.04-edge 6.5.0.9.11
>>>     linux-tools-generic-hwe-22.04 6.5.0.9.11
>>>     linux-tools-generic 6.5.0.9.11
>>> You should explicitly select one to install.
>>>
>>> E: Package 'linux-tools' has no installation candidate
>>>
>>> The above should list linux-tools-raspi on ARM.
>>>
>>> [Fix]
>>>
>>> Add 'Provides: linux-tools' and 'Provides: linux-cloud-tools' to all meta
>>> packages that are missing them.
>>>
>>> [Test Case]
>>>
>>> See [Impact] above. The list of installation candidates should show the fixed
>>> meta package name.
>>>
>>> [Regression Potential]
>>>
>>> Can't think of any problems this might cause. Most meta packages are correct
>>> and we would have noticed issues by now (I hope).
>>>    
>>
>> Would this not better be a scripted update?
> 
> Yes. I could do a bulk update if I get 2 ACKs. The following should be fixed.
> Note that I've added focal as well.
> 
> Basically all of azure, raspi, kvm and denver.
> 
> focal/linux-meta-azure-5.11:debian/control.d/azure
> focal/linux-meta-azure-5.13:debian/control.d/azure
> focal/linux-meta-azure-5.15:debian/control.d/azure
> focal/linux-meta-azure-5.8:debian/control.d/azure
> focal/linux-meta-azure-cvm:debian/control.d/azure-cvm
> focal/linux-meta-azure-fde-5.15:debian/control.d/azure-fde
> focal/linux-meta-azure-fde:debian/control.d/azure-fde
> focal/linux-meta-azure:debian/control.d/azure
> focal/linux-meta-denver:debian/control.d/denver
> focal/linux-meta-kvm:debian/control.d/kvm
> focal/linux-meta-raspi2:debian/control.d/raspi2
> focal/linux-meta-raspi:debian/control.d/raspi
> jammy/linux-meta-azure-5.19:debian/control.d/azure
> jammy/linux-meta-azure-6.2:debian/control.d/azure
> jammy/linux-meta-azure-6.5:debian/control.d/azure
> jammy/linux-meta-azure-fde-5.19:debian/control.d/azure-fde
> jammy/linux-meta-azure-fde-6.2:debian/control.d/azure-fde
> jammy/linux-meta-azure-fde:debian/control.d/azure-fde
> jammy/linux-meta-azure:debian/control.d/azure
> jammy/linux-meta-kvm:debian/control.d/kvm
> jammy/linux-meta-raspi:debian/control.d/raspi
> lunar/linux-meta-azure:debian/control.d/azure
> lunar/linux-meta-kvm:debian/control.d/kvm
> lunar/linux-meta-raspi:debian/control.d/raspi
> mantic/linux-meta-azure:debian/control.d/azure
> mantic/linux-meta-raspi:debian/control.d/raspi
> 
> ...Juerg
I can agree with adding a provides for linux-tools. Though for this a 
single email, possibly with an example would have been enough. It could 
describe which places would be updated and how. And how this should be 
rolled out. All of this somewhat got drowned by the huge amount of near 
identical patches.

Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20231025/09fe100d/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20231025/09fe100d/attachment-0001.sig>