NACK/Cmnt: [SRU][mantic:linux-gcp, lunar:linux-gcp][PATCH 0/1] SEV_SNP failure to init

[Stefan Bader]

On 11.10.23 17:17, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2037316
> 

Rejected for the following reasons:
- the bug reference (above) is already in progress. Once a submission 
has been
  made you cannot use it for follow-ups. There is no sane way this can 
be tracked.
  There was a submission already which  is fix committed (that means 
something
  is applied to the current SRU cycle and this will be moved to fix 
released once
  the kernel releases).
- the change itself would also make sense to the distro kernels. I can 
see the
   need/desire to fix it in GCP as quickly as possible but I would 
prefer to see that
   also targeted to mantic,lunar:linux (the bug report you re-used did 
this as well).
- the pick from non-standard repos should be avoided (could still be work in
   progress). Better is to wait for it to appear on linux-next (which 
has happened
   now). Then it does not need to be SAUCE and has at least made one 
more step
   towards acceptance. This seems to be part of a whole bunch of fixes 
for SEV
   but has no cc:stable which might pose a risk it is not arriving via 
stable.

-Stefan

> [Impact]
> 
> * Kernel OOPS encountered on 32-bit kernels due to commit cd0e9ab from
>    git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-gcp/+git/lunar
> 
> [Fix]
> 
> * Clean cherry pick from https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * To be tested by Google
> 
> [Where things could go wrong]
> 
> * Low chance of regression, isolated fix slightly modifying when value becomes
>    available.
> 
> Dave Hansen (1):
>    x86/boot: Move x86_cache_alignment initialization to correct spot
> 
>   arch/x86/kernel/cpu/common.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20231012/6ed246df/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20231012/6ed246df/attachment-0001.sig>