> > + gs->valid_mask = 0x0; > > Isn't this ^ superfluous ? It appears that gs->valid_mask is overwritten in the > call to device_property_read_u32(). > > > + device_property_read_u32(dev, "valid_mask", > > +&gs->valid_mask); > > + Thanks for catching that. Sent v2.