ACK: [PATCH 0/1] [j:linux-intel-iotg][j:linux-intel-iot-realtime] Cannot set frame preemption on i225 NICs

[Tim Gardner]

On 10/3/23 11:23 AM, Philip Cox wrote:
> 
> BugLink: https://bugs.launchpad.net/bugs/2038349
> 
> SRU Justification:
> 
> [Impact]
> Unable to enable frame pre-emption on intel i225 NICs.
> 
> ubuntu at adl-s:~$ sudo ethtool-rt.ethtool --set-frame-preemption  enp169s0 fp on ; echo $?
> netlink error: frame preemption settings update failed
> netlink error: Invalid argument
> 81
> ubuntu at adl-s:~$
> 
> 
> [Fix]
> The default frag size was not being set for the NIC driver.  The code was returning out of the function early before setting the value. This return has been removed so the value is set.
> 
> [Test Plan]
> Intel has provided the fix, and they have tested it.  I have tested it as well.
> 
> Before the change:
> ubuntu at adl-s:~$ sudo ethtool-rt.ethtool --set-frame-preemption  enp169s0 fp on ; echo $?
> netlink error: frame preemption settings update failed
> netlink error: Invalid argument
> 81
> ubuntu at adl-s:~$
> 
> After the change:
> ubuntu at adl-s:~$ sudo ethtool-rt.ethtool --set-frame-preemption  enp169s0 fp on ; echo $?
> 0
> ubuntu at adl-s:~$
> 
> 
> [Where problems could occur]
> The should not be any regressions due to how narrow the scope of this change is, and as it is setting a value to what the default value should be, there should not be any regressions.  The scope is fairly limited, and the change is fairly confined.
> 
> ---
> 
> Lai Peter Jun Ann (1):
>    UBUNTU: SAUCE: (no-up) igc: fix frame preemption not able to set
> 
>   drivers/net/ethernet/intel/igc/igc_tsn.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>
-- 
-----------
Tim Gardner
Canonical, Inc