Cmnt: [SRU][Noble][PATCH 0/1] Enable CONFIG_COMMON_CLK_MT8188 and CONFIG_MTK_PMIC_WRAP as built-in on arm64

[Emil Renner Berthing]

Jian Hui Lee wrote:
> Hi Emil,
>
> On Mon, Nov 20, 2023 at 7:03 PM Emil Renner Berthing
> <emil.renner.berthing at canonical.com> wrote:
> >
> > Jian Hui Lee wrote:
> > > BugLink: https://bugs.launchpad.net/bugs/2043962
> > >
> > > [Impact]
> > > emmc storage is not usable after booting.
> > >
> > > [Fix]
> > > CONFIG_COMMON_CLK_MT8188 and CONFIG_MTK_PMIC_WRAP need to be built-in to supply clock and power as early as possible, in order to have the emmc storage for further installation.
> >
> > From this description it's not quite clear to me why those modules need to be
> > built in and not just be available in the initramfs.
> >
> > /Emil
>
> both of the modules were in initramfs already but still not be able to
> bring up the emmc successfully. according to mediatek, these two
> drivers should be built-in for further peripherals usage.
> the description is also updated in the buglink.

Yeah, it's nice that you tried, but it would still be nice with an explanation
of why it doesn't work as modules. Either it's a bug in the driver or if there
is some reason it can never work as module then the Kconfig should really be
"bool" and not "tristate". Either way this seems like a bug that would be nice
to have fixed upstream.

/Emil

> > > [Test Case]
> > > 1. build test.
> > > 2. testing on the target device, mediatek g1200 evk board, and check the emmc storage could be recognized and mountable after booting.
> > >
> > > [Where problems could occur]
> > > the risk would be low because both drivers are only used on mediatek platform.
> > >
> > > [Other info]
> > > the purpose of this is to make ubuntu as an arm systemready ir distribution for mediatek platform.
> > >
> > >
> > > Jian Hui Lee (1):
> > >   UBUNTU: [Config] Enable CONFIG_COMMON_CLK_MT8188 and
> > >     CONFIG_MTK_PMIC_WRAP as built-in on arm64
> > >
> > >  debian.master/config/annotations | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > --
> > > 2.40.1
> > >
> > >
> > > --
> > > kernel-team mailing list
> > > kernel-team at lists.ubuntu.com
> > > https://lists.ubuntu.com/mailman/listinfo/kernel-team