NAK: [PATCH 0/1][SRU][Unstable/Mantic] Add XB-Modaliases field for standalone linux-modules-foo-* packages

[Dimitri John Ledkov]

On Thu, 9 Nov 2023, 15:55 Tim Gardner, <tim.gardner at canonical.com> wrote:

> On 10/13/23 07:37, You-Sheng Yang wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2021740
> >
> > [Impact]
> >
> > Need modaliases info for ubuntu-drivers integration.
> >
> > [Fix]
> >
> > This Ubuntu sauced patch copies modaliases info from source dkms deb
> packages to
> > standalone `linux-modules-<mod>-<version>-<variant>` ones if available.
> >
> > [Test Case]
> >
> > ```bash
> > $ sudo add-apt-repository ppa:canonical-hwe-team/experimental-unstable
> > $ apt-cache show linux-modules-ivsc-6.6.0-9005-generic | grep Modaliases
> > Modaliases: mei-vsc(acpi*:INTC1009:*, acpi*:INTC1058:*,
> acpi*:INTC1094:*, acpi*:INTC10D0:*)
> > ```
> >
> > [Where problems could occur]
> >
> > With **XB-Modaliases** field added to deb control, `ubuntu-drivers` will
> then
> > give a list of installable `linux-modules-<mod>-<version>-<variant>`
> candidates
> > on available platforms. So far based on current `debian/dkms-versions`,
> the only
> > one will be enabled will be ivsc-driver, and ipu6-drivers to be SRUed
> soon.
>


I believe this will result in any system installing any kernel abi flavour.

I.e. -generic system with ipu6 offering to install -aws kernel modules and
linux-image-aws.

Thus we should not land this without coordinating changes in ubuntu-drivers
that would otherwise offer to switch ABI flavour.

Also, I am inclined to simply add modules-extra to recommend modules-ipu6 &
modules-vsc and be done with it.

It will fix majority of ipu6 users. It may provide a different sensor
module for some, and they can uninstall modules-ipu6 if that causes them to
experience a different sensor.

>
> > [Other Info]
> >
> > To nominate Unstable/Mantic/Lunar/OEM-6.5/OEM-6.1.
> >
> > Note that this adds a build-dep to dh-modaliases from universe pocket.
> >
>
> Isn't adding a universe dependency to a main archive package kinda
> verboten ?
>

This is allowed, since the last reorg -
https://lists.ubuntu.com/archives/ubuntu-devel/2016-February/039188.html

As long as runtime depends are not generated as a result of this - or in
turn split published to universe. (Prime example boost - build depends on
universe openmpi, and published boost-mpi subpackage into universe, whilst
all other things are in main).



> > You-Sheng Yang (1):
> >    UBUNTU: [Packaging] support modaliases for standalone dkms packages
> >
> >   debian.master/control.stub.in        |  1 +
> >   debian/control.d/flavour-module.stub |  1 +
> >   debian/rules                         |  1 +
> >   debian/rules.d/2-binary-arch.mk      | 10 +++++++++-
> >   debian/scripts/dkms-build            |  9 +++++++++
> >   5 files changed, 21 insertions(+), 1 deletion(-)
> >
>
> --
> -----------
> Tim Gardner
> Canonical, Inc
>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20231109/f9b980fd/attachment.html>