NAK: [SRU][J:linux-bluefield][PATCH v2 0/7] Support hardware miss to tc action

[Bartlomiej Zolnierkiewicz]

On Mon, May 15, 2023 at 9:26 PM William Tu <witu at nvidia.com> wrote:
>
> Currently tc miss interface only supports resuming from a specific tc chain.
> If a packet modification is done before a missable action such as CT and
> there is a miss in CT after it, this may cause a miss match when resuming
> re-executing the same chain in software, and wrong packet count.
>  This use case for example is a stateless (static) nat.
>
> * brief explanation of fixes
> Add support for missing to a specific action instance, and support
> of per action hardware stats to update what was actually done in hardware.
>
> BugLink: https://bugs.launchpad.net/bugs/2012571
>
> Note:
> We previously sent this patch to Focal but revert the series due
> to some issue. For Jammy, there is no such issue so we'd like to
> merge this series to Jammy, while in the meantime working on solving
> the Focal issue, thanks.
>
> And because this has been review for Focal, and no code change, I propagate
> the acks/review tags.

This doesn't seem to be correct. For Focal the patch #5 in the series
was a cherry-pick of a commit dfd2f0eb2347 ("net/sched: flower: fix
fl_change() error recovery path") for Jammy the patch #5 is a
cherry-pick of commit 9b7c68b3911a ("netfilter: ctnetlink: Support
offloaded conntrack entry deletion"). The latter patch references
different BugLink and was a separate submission for Focal (the same
should be done for Jammy). Since the cherry-pick of a commit
dfd2f0eb2347 is missing the patch #7 was actually backported and not
cherry-picked (as it should be).

Please fix the above issues. Also while at it please:

- remove mention of "linux-next" from the cherry-pick line of commit
9b7c68b3911a ("netfilter: ctnetlink: Support offloaded conntrack entry
deletion") as the commit was merged in the upstream tree

- include fixes for commit 80cd22c35c90 ("net/sched: cls_api: Support
hardware miss to tc action") from upstream:
  * commit 2cc8a008d62f ("net/sched: cls_api: Initialize
miss_cookie_node when action miss is not used")
  * commit 338469d677e5 ("net/sched: clear actions pointer in miss
cookie init fail")
  * commit 37e1f3acc339 ("net/sched: cls_api: Move call to
tcf_exts_miss_cookie_base_destroy()")

--
Best regards,
Bartlomiej

> v1->v2:
> add two more patches from Vlad, show below
>
> Paul Blakey (5):
>   UBUNTU: SAUCE: net/sched: Provide act to offload action
>   net/sched: cls_api: Support hardware miss to tc action
>   net/sched: flower: Move filter handle initialization earlier
>   net/sched: flower: Support hardware miss to tc action
>   netfilter: ctnetlink: Support offloaded conntrack entry deletion
>
> Vlad Buslov (2):
>   net/sched: flower: fix filter idr initialization
>   net/sched: flower: fix error handler on replace
>
>  include/linux/skbuff.h               |   6 +-
>  include/net/flow_offload.h           |   2 +
>  include/net/pkt_cls.h                |  30 ++--
>  include/net/sch_generic.h            |   2 +
>  net/netfilter/nf_conntrack_netlink.c |   8 -
>  net/openvswitch/flow.c               |   3 +-
>  net/sched/cls_api.c                  | 216 +++++++++++++++++++++++++--
>  net/sched/cls_flower.c               |  76 ++++++----
>  8 files changed, 285 insertions(+), 58 deletions(-)