NAK: [SRU][F:linux-bluefield][PATCH v2 0/1] net: openvswitch: fix race on port output

[Tim Gardner]

On 5/24/23 10:31 AM, William Tu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2020606
> 
> fix race on port output
> 
> * Explain the bug(s)
> 
> there is a race condition on port output
> 
> * brief explanation of fixes
> 
> We found that upstream linux has the same issue and fix
> commit 066b86787fa3d97b7aefb5ac0a99a22dad2d15f8
>      net: openvswitch: fix race on port output
> 
> * How to test
> After configuring QoS on BF-3:
> Disable all priorities
> Set priorities [0, 0, 0, 0, 0, 0, 0, 0]
> Remove all policies
> Remove all traffic classes
> Add policy (policy_name=ND_traffic, traffic_type=RDMA, priority=5, port=20000, dscp=None)
> Add policy (policy_name=TCP_traffic, traffic_type=TCP, priority=4, port=26000, dscp=None)
> Add traffic class two prio TC with prio_list=[5, 4], min_bw=76, algorithm=ETS
> Enable QOS on adapter SLOT 5 Port 1
> Restart driver (detach VFs -> restart with devcon -> attach VFs)
> 
> BF-3 sometimes stops responding. need to run it multiple times!
> 
> v2:
> Separate focal and jammy
> 
> Felix Huettner (1):
>    net: openvswitch: fix race on port output
> 
>   net/core/dev.c            | 1 +
>   net/openvswitch/actions.c | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
Maybe you should test build first:

/build/focal/net/core/dev.c: In function 'skb_tx_hash':
/build/focal/net/core/dev.c:2977:3: error: implicit declaration of 
function 'DEBUG_NET_WARN_ON_ONCE' [-Werror=implicit-function-declaration]
  2977 |   DEBUG_NET_WARN_ON_ONCE(qcount == 0);

-- 
-----------
Tim Gardner
Canonical, Inc