ACK/Cmnt: [SRU][J:linux-bluefield][PATCH v2 0/7] Support hardware miss to tc action

[Tim Gardner]

On 5/15/23 1:25 PM, William Tu wrote:
> Currently tc miss interface only supports resuming from a specific tc chain.
> If a packet modification is done before a missable action such as CT and
> there is a miss in CT after it, this may cause a miss match when resuming
> re-executing the same chain in software, and wrong packet count.
>   This use case for example is a stateless (static) nat.
> 
> * brief explanation of fixes
> Add support for missing to a specific action instance, and support
> of per action hardware stats to update what was actually done in hardware.
> 
> BugLink: https://bugs.launchpad.net/bugs/2012571
> 
> Note:
> We previously sent this patch to Focal but revert the series due
> to some issue. For Jammy, there is no such issue so we'd like to
> merge this series to Jammy, while in the meantime working on solving
> the Focal issue, thanks.
> 
> And because this has been review for Focal, and no code change, I propagate
> the acks/review tags.
> 

Be careful when propagating ACKs. Patches are reviewed in the context of 
a specific kernel version. Just because they work for one kernel doesn't 
mean they are right for another. In this case the code is similar enough...

> v1->v2:
> add two more patches from Vlad, show below
> 
> Paul Blakey (5):
>    UBUNTU: SAUCE: net/sched: Provide act to offload action
>    net/sched: cls_api: Support hardware miss to tc action
>    net/sched: flower: Move filter handle initialization earlier
>    net/sched: flower: Support hardware miss to tc action
>    netfilter: ctnetlink: Support offloaded conntrack entry deletion
> 
> Vlad Buslov (2):
>    net/sched: flower: fix filter idr initialization
>    net/sched: flower: fix error handler on replace
> 
>   include/linux/skbuff.h               |   6 +-
>   include/net/flow_offload.h           |   2 +
>   include/net/pkt_cls.h                |  30 ++--
>   include/net/sch_generic.h            |   2 +
>   net/netfilter/nf_conntrack_netlink.c |   8 -
>   net/openvswitch/flow.c               |   3 +-
>   net/sched/cls_api.c                  | 216 +++++++++++++++++++++++++--
>   net/sched/cls_flower.c               |  76 ++++++----
>   8 files changed, 285 insertions(+), 58 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>
-- 
-----------
Tim Gardner
Canonical, Inc