NAK: [SRU][J:linux-bluefield][PATCH v1 0/5] Support hardware miss to tc action

Tim Gardner tim.gardner at canonical.com
Tue May 23 12:32:14 UTC 2023


On 5/15/23 8:54 AM, William Tu wrote:
> We’ve found two dependencies of this series.
> 
> I’m planning to send v2 with it, thanks!
> 
> William
> 
> *From: *William Tu <witu at nvidia.com>
> *Date: *Thursday, May 11, 2023 at 10:39 AM
> *To: *kernel-team at lists.ubuntu.com <kernel-team at lists.ubuntu.com>
> *Cc: *Bodong Wang <bodong at nvidia.com>, Vladimir Sokolovsky 
> <vlad at nvidia.com>, dann.frazier at canonical.com 
> <dann.frazier at canonical.com>, Paul Blakey <paulb at nvidia.com>, William Tu 
> <witu at nvidia.com>, Tony Duan <yifeid at nvidia.com>
> *Subject: *[SRU][J:linux-bluefield][PATCH v1 0/5] Support hardware miss 
> to tc action
> 
> Currently tc miss interface only supports resuming from a specific tc chain.
> If a packet modification is done before a missable action such as CT and
> there is a miss in CT after it, this may cause a miss match when resuming
> re-executing the same chain in software, and wrong packet count.
>   This use case for example is a stateless (static) nat.
> 
> * brief explanation of fixes
> Add support for missing to a specific action instance, and support
> of per action hardware stats to update what was actually done in hardware.
> 
> BugLink: https://bugs.launchpad.net/bugs/2012571 
> <https://bugs.launchpad.net/bugs/2012571>
> 
> Note:
> We previously sent this patch to Focal but revert the series due
> to some issue. For Jammy, there is no such issue so we'd like to
> merge this series to Jammy, while in the meantime working on solving
> the Focal issue, thanks.
> 
> And because this has been review for Focal, and no code change, I propagate
> the acks/review tags.
> 
> Paul Blakey (5):
>    UBUNTU: SAUCE: net/sched: Provide act to offload action
>    net/sched: cls_api: Support hardware miss to tc action
>    net/sched: flower: Move filter handle initialization earlier
>    net/sched: flower: Support hardware miss to tc action
>    netfilter: ctnetlink: Support offloaded conntrack entry deletion
> 
>   include/linux/skbuff.h               |   6 +-
>   include/net/flow_offload.h           |   2 +
>   include/net/pkt_cls.h                |  30 ++--
>   include/net/sch_generic.h            |   2 +
>   net/netfilter/nf_conntrack_netlink.c |   8 -
>   net/openvswitch/flow.c               |   3 +-
>   net/sched/cls_api.c                  | 216 +++++++++++++++++++++++++--
>   net/sched/cls_flower.c               |  73 +++++----
>   8 files changed, 283 insertions(+), 57 deletions(-)
> 
> -- 
> 2.34.1
> 
> 

Tie off this thread while awaiting v2.
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list