ACK/Cmnt: [SRU][jammy:linux-intel-iotg][PULL][v2] Raptor Lake: Enable TGPIO

[Tim Gardner]

On 5/2/23 16:58, Philip Cox wrote:
> BugLink:https://bugs.launchpad.net/bugs/2018282 
> <https://bugs.launchpad.net/bugs/2018282>
> 
> SRU Justification:
> 
> [Impact]
> Adding support for TGPIO for Intel Raptor Lake platform
> 
> [Fix]
> This is a series of patches to add support for TGPIO for the Intel 
> Raptor Lake platform
> 
> 
> [Test Plan]
> I've performed some testing Raptor Lake, and the QA team, and Intel will 
> be performing more thorough testing once a kernel with this support is 
> available in an IOTG image.
> 
> [Where problems could occur]
> This is a backport from a 5.19 kernel. Most of the patches had some 
> minor context changes, but there were no major changes required. There 
> is a chance that the behaviour has changed for previous platforms and 
> the existing functionality is altered. I believe this is not likely, as 
> most of the patches seem to be extending functionality, rather than 
> changing the flow of existing code for the most part.
> 
> [v2]
> Subject change
> ----------------------------------------------------------------
> 
> The following changes since commit eee29863cc23b88440594cf17517ce648fe02ec1:
> 
> UBUNTU: Ubuntu-intel-iotg-5.15.0-1029.34 (2023-04-28 06:39:34 -0400)
> 
> are available in the Git repository at:
> 
> git://git.launchpad.net/~philcox/+git/kreview philcox/lp2018282
> 
> for you to fetch changes up to 0867f73de4129190d732e13e52330a2009a221cf:
> 
> ptp: Enable preempt if it is disabled (2023-05-02 11:18:34 +0200)
> 
> ----------------------------------------------------------------
> Christopher Hall (1):
> Kernel Argument Bypassing ART Detection
> 
> D, Lakshmi Sowjanya (3):
> ptp: tgpio: PSE TGPIO crosststamp, counttstamp
> ptp: S/W workaround for PMC TGPIO h/w bug
> ptp: Fix for PSE TGPIO Oneshot output and counttstamp
> 
> Hao Li (2):
> tgpio: Fix compilation errors for PSE TGPIO
> drivers/ptp: Add COMPV GPIO Mode for PSE TGPIO
> 
> Lakshmi Sowjanya D (4):
> ptp: Fix for PSE TGPIO frequency Adjustment issue
> ptp: Add PTP_EVENT_COUNTER_MODE in v1 valid flags
> tools: testptp: Update period for periodic output mode
> ptp: Enable preempt if it is disabled
> 
> Padmasanan, Prathisna (1):
> GPIO: Fix for PSE GPIO generating only one event as interrupt source
> 
> Pandith N (1):
> TGPIO: Calling power management calls without entering critical section.
> 
> Rajvi Jingar (6):
> Added TGPIO pin check before input event read
> Added an Example to adjust frequency for output
> Added single-shot output mode support for TGPIO
> Added an example to poll for edges
> Added support to get TGPIO/System Clock Offset
> Added single-shot output mode option for TGPIO pin
> 
> Raymond Tan (1):
> mfd: intel-ehl-gpio: Introduce MFD framework to PSE GPIO/TGPIO
> 
> Tamal Saha (1):
> TGPIO: Fix PSE TGPIO PTP driver ioctls fail
> 
> Tan, Raymond (1):
> selftests: ptp: Added COMPV GPIO Input Mode for TGPIO
> 
> hkoayx (1):
> ptp: Introduce PTP_PINDESC_INPUTPOLL for Intel PMC TGPIO
> 
> arch/x86/include/asm/tsc.h | 2 +
> arch/x86/kernel/tsc.c | 106 ++++++++++++++++---
> drivers/gpio/Kconfig | 11 ++
> drivers/gpio/Makefile | 1 +
> drivers/gpio/gpio-ehl-pse-plat.c | 493 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/mfd/Kconfig | 12 +++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/intel-ehl-gpio.c | 248 
> +++++++++++++++++++++++++++++++++++++++++++++
> drivers/ptp/Kconfig | 11 ++
> drivers/ptp/Makefile | 1 +
> drivers/ptp/ptp-intel-pmc-tgpio.c | 26 ++++-
> drivers/ptp/ptp-intel-tgpio-plat.c | 759 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/ptp/ptp_chardev.c | 6 +-
> include/uapi/linux/ptp_clock.h | 2 +
> tools/testing/selftests/ptp/testptp.c | 213 
> +++++++++++++++++++++++++++++++++++----
> 15 files changed, 1857 insertions(+), 35 deletions(-)
> create mode 100644 drivers/gpio/gpio-ehl-pse-plat.c
> create mode 100644 drivers/mfd/intel-ehl-gpio.c
> create mode 100644 drivers/ptp/ptp-intel-tgpio-plat.c
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

Did you really have to backport all of these patches ? A couple look 
simple enough that they should have cherry picked cleanly.
-- 
-----------
Tim Gardner
Canonical, Inc