NAK: [L/Unstable] [PATCH 1/1] UBUNTU: [Config]: Disable CONFIG_INTEL_ATOMISP

[Juerg Haefliger]

On Mon, 1 May 2023 16:30:02 +0200
Tim Gardner <tim.gardner at canonical.com> wrote:

> On 5/1/23 15:35, Kai-Heng Feng wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2017444
> > 
> > The ATOMISP module makes Atom systems unbootable on kernel 6.2.
> > 
> > Hans, the driver dev suggests to disable the module until it's out of
> > staging tree.
> > 
> > So disable the module and enable the dummy driver for powersaving.
> > 
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> > ---
> >   debian.master/config/annotations | 13 ++-----------
> >   1 file changed, 2 insertions(+), 11 deletions(-)
> > 
> > diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> > index 45e6794ef25a..466cd50422e3 100644
> > --- a/debian.master/config/annotations
> > +++ b/debian.master/config/annotations
> > @@ -6224,9 +6224,10 @@ CONFIG_INTEGRITY_AUDIT                          policy<{'amd64': 'y', 'arm64': '
> >   CONFIG_INTEGRITY_MACHINE_KEYRING                policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'riscv64': 'y'}>
> >   CONFIG_INTEGRITY_SIGNATURE                      policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>
> >   CONFIG_INTEGRITY_TRUSTED_KEYRING                policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>
> > -CONFIG_INTEL_ATOMISP                            policy<{'amd64': 'y'}>
> > +CONFIG_INTEL_ATOMISP                            policy<{'amd64': 'n'}>

Add a note with a bug reference:
CONFIG_INTEL_ATOMISP                            policy<{'amd64': 'n'}> note<'LP: #2017444'>


> >   CONFIG_INTEL_ATOMISP2_LED                       policy<{'amd64': 'm'}>
> >   CONFIG_INTEL_ATOMISP2_PDX86                     policy<{'amd64': 'y'}>
> > +CONFIG_INTEL_ATOMISP2_PM                        policy<{'amd64': 'm'}>

And here:
CONFIG_INTEL_ATOMISP2_PM                        policy<{'amd64': 'm'}> note<'LP: #2017444'>

And add some comment to the commit message that explains why this driver
should be enabled. Something like 'enable the dummy powersaving driver which
turns the ISP off'. 


> >   CONFIG_INTEL_BXTWC_PMIC_TMU                     policy<{'amd64': 'm'}>
> >   CONFIG_INTEL_BXT_PMIC_THERMAL                   policy<{'amd64': 'm'}>
> >   CONFIG_INTEL_CHTDC_TI_PWRBTN                    policy<{'amd64': 'm'}>
> > @@ -14074,16 +14075,6 @@ CONFIG_VIDEO_AMPHION_VPU                        policy<{'arm64': 'm', 'armhf': '
> >   CONFIG_VIDEO_APTINA_PLL                         policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm'}>
> >   CONFIG_VIDEO_AR0521                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm'}>
> >   CONFIG_VIDEO_ASPEED                             policy<{'amd64': '-', 'arm64': '-', 'armhf': 'm', 'ppc64el': '-', 'riscv64': '-'}>
> > -CONFIG_VIDEO_ATOMISP                            policy<{'amd64': 'm'}>
> > -CONFIG_VIDEO_ATOMISP_GC0310                     policy<{'amd64': 'm'}>
> > -CONFIG_VIDEO_ATOMISP_GC2235                     policy<{'amd64': 'm'}>
> > -CONFIG_VIDEO_ATOMISP_ISP2401                    policy<{'amd64': 'y'}>
> > -CONFIG_VIDEO_ATOMISP_LM3554                     policy<{'amd64': 'm'}>
> > -CONFIG_VIDEO_ATOMISP_MSRLIST_HELPER             policy<{'amd64': 'm'}>
> > -CONFIG_VIDEO_ATOMISP_MT9M114                    policy<{'amd64': 'm'}>
> > -CONFIG_VIDEO_ATOMISP_OV2680                     policy<{'amd64': 'm'}>
> > -CONFIG_VIDEO_ATOMISP_OV2722                     policy<{'amd64': 'm'}>
> > -CONFIG_VIDEO_ATOMISP_OV5693                     policy<{'amd64': 'm'}>
> >   CONFIG_VIDEO_AU0828                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm'}>
> >   CONFIG_VIDEO_AU0828_RC                          policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y'}>
> >   CONFIG_VIDEO_AU0828_V4L2                        policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y'}>  
> 
> Did this build ? Shouldn't the module check have complained about 
> missing modules?

Well yes, the ABI needs to be modified at cranky time.


> Plus, I think you need to add a note to the annotations to at least 
> reference the LP bug so we can look back months from now and know why 
> this config option was disabled.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230503/deb04006/attachment.sig>