NAK: [SRU][J:linux-bluefield][Pull Request] Support Nvidia BlueField-3 GPIO driver and pin controller

[Tim Gardner]

On 3/30/23 11:44 AM, Asmaa Mnebhi wrote:
> BugLink: https://bugs.launchpad.net/bugs/2012743
> 
> This pull request includes 5 commits in the effort to sync up
> Jammy with upstreaming:
> 1) cherry-pick 443a0a0f0cf4f432c7af6654b7f2f920d411d379
>     introduces macros needed for the pinctrl-mlxbf3.c driver
> 2) cherry-pick d11f932808dc689717e409bbc81b5093e7902fc9
>     supports the upstreamed pinctrl-mlxbf3.c driver
> 3) handle "ngpios" properly in bgpio_init()
> 4) Add gpio-mlxbf3.c driver support
> 5) Support pinctrl-mlxbf3 driver in debian build
> 
> The pull request page can be found at:
> https://code.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git/version-seeds-1/+merge/440062
> 
> Git repo can be found at:
> https://git.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git/version-seeds-1 master-next
> 
> for you to fetch starting from commit 58759cc4d49346a967bc960df600a4f99d71c3d1
> "UBUNTU: Ubuntu-bluefield-5.15.0-1014.16"
> 
> Signed-off-by: Asmaa Mnebhi <asmaa at nvidia.com>
> 
> Andy Shevchenko (1):
>    pinctrl: Introduce struct pinfunction and PINCTRL_PINFUNCTION() macro
> 
> Asmaa Mnebhi (4):
>    pinctrl: mlxbf3: Add pinctrl driver support
>    UBUNTU: SAUCE: gpio: mmio: handle "ngpios" properly in bgpio_init()
>    UBUNTU: SAUCE: gpio: mlxbf3: Add gpio driver support
>    UBUNTU: SAUCE: Support pinctrl-mlxbf3 driver in debian build
> 
>   debian.bluefield/abi/arm64/bluefield.modules |   1 +
>   debian.bluefield/config/config.common.ubuntu |   1 +
>   drivers/gpio/Kconfig                         |  10 +-
>   drivers/gpio/gpio-mlxbf3.c                   | 291 +++++++----------
>   drivers/gpio/gpio-mmio.c                     |   9 +-
>   drivers/gpio/gpiolib.c                       |  68 ++--
>   drivers/gpio/gpiolib.h                       |   1 +
>   drivers/pinctrl/Kconfig                      |  13 +
>   drivers/pinctrl/Makefile                     |   1 +
>   drivers/pinctrl/pinctrl-mlxbf3.c             | 320 +++++++++++++++++++
>   include/linux/pinctrl/pinctrl.h              |  20 ++
>   11 files changed, 520 insertions(+), 215 deletions(-)
>   create mode 100644 drivers/pinctrl/pinctrl-mlxbf3.c
> 

Patch 2 is only in linux-next; The line should be:
(cherry picked from commit d11f932808dc689717e409bbc81b5093e7902fc9 
linux-next)

Patch 3 has no Signed-off-by:

Maybe you should wait until patch 3-4 are in linux-next before your next 
pull request so you don't have such a mess of reverts when these patches 
are merged upstream.

-- 
-----------
Tim Gardner
Canonical, Inc