ACK: [K][SRU][PATCH 1/1] selftests/ftrace: Fix bash specific "==" operator

Roxana Nicolescu roxana.nicolescu at canonical.com
Thu Mar 30 10:36:29 UTC 2023


On 30/03/2023 11:11, Po-Hsu Lin wrote:
> From: "Masami Hiramatsu (Google)" <mhiramat at kernel.org>
>
> BugLink: https://bugs.launchpad.net/bugs/2006453
>
> Since commit a1d6cd88c897 ("selftests/ftrace: event_triggers: wait
> longer for test_event_enable") introduced bash specific "=="
> comparation operator, that test will fail when we run it on a
> posix-shell. `checkbashisms` warned it as below.
>
> possible bashism in ftrace/func_event_triggers.tc line 45 (should be 'b = a'):
>          if [ "$e" == $val ]; then
>
> This replaces it with "=".
>
> Fixes: a1d6cd88c897 ("selftests/ftrace: event_triggers: wait longer for test_event_enable")
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat at kernel.org>
> Reviewed-by: Steven Rostedt (Google) <rostedt at goodmis.org>
> Signed-off-by: Shuah Khan <skhan at linuxfoundation.org>
> (cherry picked from commit 1e6b485c922fbedf41d5a9f4e6449c5aeb923a32)
> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
> ---
>   tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> index 27a68bb..d9b8127 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> @@ -42,7 +42,7 @@ test_event_enabled() {
>   
>       while [ $check_times -ne 0 ]; do
>   	e=`cat $EVENT_ENABLE`
> -	if [ "$e" == $val ]; then
> +	if [ "$e" = $val ]; then
>   	    return 0
>   	fi
>   	sleep $SLEEP_TIME


Acked-by: Roxana Nicolescu <roxana.nicolescu at canonical.com>




More information about the kernel-team mailing list