NACK: [PATCH 0/1][SRU][J][K][L] Intel E810 NICs hang on boot when bonds are configured

Cory Todd cory.todd at canonical.com
Wed Mar 29 18:55:04 UTC 2023


On Thu, Mar 23, 2023 at 03:20:08PM -0300, Heitor Alves de Siqueira wrote:
> BugLink: https://bugs.launchpad.net/bugs/2004262
> 
> [Impact]
>   * Intel E810-family NICs cause system hangs when booting with bonding enabled
>   * This happens due to the driver unplugging auxiliary devices
>   * The unplug event happens under RTNL lock context, which causes a deadlock
>     where the RDMA driver waits for the RNL lock to complete removal
> 
> [Test Plan]
>   * Users have reported that after setting up bonding on switch and server
>     side, the system will hang when starting network services
> 
> [Fix]
>   * The upstream patch defers unplugging/re-plugging of the auxiliary device,
>     so that it's not performed under the RTNL lock context.
>   * Fix was introduced by commit:
>       248401cb2c46 ice: avoid bonding causing auxiliary plug/unplug under RTNL lock
> 
> [Regression Potential]
>   * Regressions would manifest in devices that support RDMA functionality and
>     have been added to a bond
>   * We should look out for auxiliary devices that haven't been properly
>     unplugged, or that cause further issues with
>     ice_plug_aux_dev()/ice_unplug_aux_dev()
> 
> Dave Ertman (1):
>   ice: avoid bonding causing auxiliary plug/unplug under RTNL lock
> 
>  drivers/net/ethernet/intel/ice/ice.h      | 14 +++++---------
>  drivers/net/ethernet/intel/ice/ice_main.c | 19 ++++++++-----------
>  2 files changed, 13 insertions(+), 20 deletions(-)
> 

The cover letter says [J][K][L] but the patches are [K] and [K][J].
Perhaps the [K][J] subject should be [K][L]?

Please adjust subject and resumbit.

- corytodd



More information about the kernel-team mailing list