ACK/Cmnt: ACK: [PATCH v2] UBUNTU: [Config] Mark CONFIG_SCSI_VIRTIO built-in

[Tim Gardner]

On 3/28/23 9:18 AM, Tim Gardner wrote:
> On 3/28/23 8:51 AM, Dimitri John Ledkov wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1685291
>> BugLink: https://bugs.launchpad.net/bugs/1931841
>> BugLink: https://bugs.launchpad.net/bugs/2006488
>>
>> This enables initrd-less boot on generic kernel, enabling any Ubuntu
>> installation to be lifted from any hardware and converted into a VM
>> which will, even with corrupted initrd and missing modules, be able to
>> boot by default. This is an extremly useful property to have on all
>> ubuntu kernels. Separately, this also removes the need for linux-kvm
>> kernel flavour, as all the changes it has are now incorporated into
>> generic flavour & cloud-images.
>>
>> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
>> ---
>>
>>   Changes since v1:
>>   - add buglinks
>>   - improve annotations comment
>>
>>   debian.master/config/annotations | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/debian.master/config/annotations 
>> b/debian.master/config/annotations
>> index bc466d7318..4017f1f651 100644
>> --- a/debian.master/config/annotations
>> +++ b/debian.master/config/annotations
>> @@ -528,8 +528,8 @@ CONFIG_SCSI_IPR_DUMP                            
>> note<'LP: #1343109'>
>>   CONFIG_SCSI_IPR_TRACE                           policy<{'amd64': 
>> 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y'}>
>>   CONFIG_SCSI_IPR_TRACE                           note<'LP: #1343109'>
>> -CONFIG_SCSI_VIRTIO                              policy<{'amd64': 'm', 
>> 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm', 's390x': 
>> 'm'}>
>> -CONFIG_SCSI_VIRTIO                              note<'tech preview of 
>> new feature'>
>> +CONFIG_SCSI_VIRTIO                              policy<{'amd64': 'y', 
>> 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 
>> 'y'}>
>> +CONFIG_SCSI_VIRTIO                              note<'enable 
>> initrdless boot in VMs for ease of use, cloud-kernel parity and 
>> disaster recovery'>
>>   CONFIG_SECURITY_SAFESETID                       policy<{'amd64': 
>> 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 
>> 's390x': 'y'}>
>>   CONFIG_SECURITY_SAFESETID                       note<'LP: #1845391'>
> 
> Can you add the LP bug numbers to the note ? Eons from now when someone 
> is thinking about this change, there may be discussion in the LP bug 
> that is of interest.
Acked-by: Tim Gardner <tim.gardner at canonical.com>

My previous comment was meant to be an ACK, along with suggestions for 
the minor changes suggested by Stefan and myself.
-- 
-----------
Tim Gardner
Canonical, Inc