ACK/Cmnt: [PATCH v2] UBUNTU: [Config] Mark CONFIG_SCSI_VIRTIO built-in

[Andrea Righi]

On Tue, Mar 28, 2023 at 03:51:32PM +0100, Dimitri John Ledkov wrote:
> BugLink: https://bugs.launchpad.net/bugs/1685291
> BugLink: https://bugs.launchpad.net/bugs/1931841
> BugLink: https://bugs.launchpad.net/bugs/2006488
> 
> This enables initrd-less boot on generic kernel, enabling any Ubuntu
> installation to be lifted from any hardware and converted into a VM
> which will, even with corrupted initrd and missing modules, be able to
> boot by default. This is an extremly useful property to have on all
> ubuntu kernels. Separately, this also removes the need for linux-kvm
> kernel flavour, as all the changes it has are now incorporated into
> generic flavour & cloud-images.
> 
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
> ---

I suggested this change a long time ago, so I'm all for this!

About the target series, I'd apply this to lunar only first. And I agree
with Stefan about picking a single tracker that summarizes the main
topic (like LP: #1685291) and maybe add a reference to the other bugs in
the tracker itself, i.e. as a comment.

Moreover, as suggested by Tim, adding a LP: #NNN in the note<> in
annotations, in addition to the description, also helps for future
references.

With all of the above:

Acked-by: Andrea Righi <andrea.righi at canonical.com>

> 
>  Changes since v1:
>  - add buglinks
>  - improve annotations comment
> 
>  debian.master/config/annotations | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index bc466d7318..4017f1f651 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -528,8 +528,8 @@ CONFIG_SCSI_IPR_DUMP                            note<'LP: #1343109'>
>  CONFIG_SCSI_IPR_TRACE                           policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y'}>
>  CONFIG_SCSI_IPR_TRACE                           note<'LP: #1343109'>
>  
> -CONFIG_SCSI_VIRTIO                              policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm', 's390x': 'm'}>
> -CONFIG_SCSI_VIRTIO                              note<'tech preview of new feature'>
> +CONFIG_SCSI_VIRTIO                              policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>
> +CONFIG_SCSI_VIRTIO                              note<'enable initrdless boot in VMs for ease of use, cloud-kernel parity and disaster recovery'>
>  
>  CONFIG_SECURITY_SAFESETID                       policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>
>  CONFIG_SECURITY_SAFESETID                       note<'LP: #1845391'>
> -- 
> 2.34.1