[SRU][F:linux-bluefield][PATCH v1 2/5] net/sched: cls_api: Support hardware miss to tc action

[Bartlomiej Zolnierkiewicz]

On Tue, Mar 28, 2023 at 6:39 PM Bartlomiej Zolnierkiewicz
<bartlomiej.zolnierkiewicz at canonical.com> wrote:
>
> On Thu, Mar 23, 2023 at 8:18 PM William Tu <witu at nvidia.com> wrote:
> >
> > From: Paul Blakey <paulb at nvidia.com>
> >
> > BugLink: https://bugs.launchpad.net/bugs/2012571
> >
> > For drivers to support partial offload of a filter's action list,
> > add support for action miss to specify an action instance to
> > continue from in sw.
> >
> > CT action in particular can't be fully offloaded, as new connections
> > need to be handled in software. This imposes other limitations on
> > the actions that can be offloaded together with the CT action, such
> > as packet modifications.
> >
> > Assign each action on a filter's action list a unique miss_cookie
> > which drivers can then use to fill action_miss part of the tc skb
> > extension. On getting back this miss_cookie, find the action
> > instance with relevant cookie and continue classifying from there.
> >
> > Signed-off-by: Paul Blakey <paulb at nvidia.com>
> > (Backported from upstream commit 80cd22c35c9001fe72bf614d29439de41933deca)
>
> The preferred format is:
>
> (backported from commit 80cd22c35c9001fe72bf614d29439de41933deca)
>
> The above line should be put before your "Signed-off-by:" line if the
> backport has been done by you.
>
> Also please try to put a short summary of changes done during
> backporting (this backport looks fine but it is far from trivial).
>
> > Reviewed-by: Jiri Pirko <jiri at nvidia.com>
> > Reviewed-by: Simon Horman <simon.horman at corigine.com>
> > Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
> > Acked-by: Jamal Hadi Salim <jhs at mojatatu.com>
> > Signed-off-by: Jakub Kicinski <kuba at kernel.org>
>
> Your "Signed-off-by:" is also needed here.
>
> So all together it should look more like:
>
> Signed-off-by: Paul Blakey <paulb at nvidia.com>
> Reviewed-by: Jiri Pirko <jiri at nvidia.com>
> Reviewed-by: Simon Horman <simon.horman at corigine.com>
> Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
> Acked-by: Jamal Hadi Salim <jhs at mojatatu.com>
> Signed-off-by: Jakub Kicinski <kuba at kernel.org>
> (backported from commit 80cd22c35c9001fe72bf614d29439de41933deca)
> [witu: adjust for context differences and lack of tc_setup_action()]
> Signed-off-by: William Tu <witu at nvidia.com>

and if the backport has been actually done by Paul it should be something like:

Signed-off-by: Paul Blakey <paulb at nvidia.com>
Reviewed-by: Jiri Pirko <jiri at nvidia.com>
Reviewed-by: Simon Horman <simon.horman at corigine.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
Acked-by: Jamal Hadi Salim <jhs at mojatatu.com>
Signed-off-by: Jakub Kicinski <kuba at kernel.org>
(backported from commit 80cd22c35c9001fe72bf614d29439de41933deca)
[paulb: adjust for context differences and lack of tc_setup_action()]
Signed-off-by: Paul Blakey <paulb at nvidia.com>
Signed-off-by: William Tu <witu at nvidia.com>

Best Regards,
Bartlomiej