ACK/Cmnt: [PATCH 0/9][SRU][L] Lost display on built-in monitor after suspend

[Tim Gardner]

On 3/28/23 2:32 AM, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> 
> BugLink: https://launchpad.net/bugs/2001599
> 
> [Impact]
> On some laptops, the eDP blinking slowly after resuming from S3
> 
> [Fix]
> The series of patches which are in drp-tip(v6.3-rc1) fix the isue
> https://patchwork.freedesktop.org/series/110693/
> 
> 4c0eb35fc103 drm/i915: Improve PPS debugs
> ed5509d1d451 drm/i915: Fix whitespace
> 1e47e035bb73 drm/i915: Print the PPS registers using consistent format
> ba21bb24810f drm/i915: Reject unusable power sequencers
> d83804f22d85 drm/i915: Extend dual PPS handlind for ICP+
> bf38bba3e7d6 drm/i915: Try to use the correct power sequencer intiially on bxt/glk
> 209074fd5a82 drm/i915: Generalize the PPS vlv_pipe_check() stuff
> 3f9ffce5765d drm/i915: Do panel VBT init early if the VBT declares an explicit panel type
> f70f8153e364 drm/i915: Introduce intel_panel_init_alloc()
> 
> [Test]
> ODM and I confirmed the issue is fixed after the patches have been applied.
> 
> [Where problems may occur]
> This series of patches fixes a dedicate issue and change the power
> sequence for the eDP panel. eDP panel may stay blank if the rules are wrong.
> OEM kernel has carried this series of patches since early Feb., we didn't
> get any report about the panel issue.
> 
> Ville Syrjälä (9):
>    drm/i915: Introduce intel_panel_init_alloc()
>    drm/i915: Do panel VBT init early if the VBT declares an explicit
>      panel type
>    drm/i915: Generalize the PPS vlv_pipe_check() stuff
>    drm/i915: Try to use the correct power sequencer intiially on bxt/glk
>    drm/i915: Extend dual PPS handlind for ICP+
>    drm/i915: Reject unusable power sequencers
>    drm/i915: Print the PPS registers using consistent format
>    drm/i915: Fix whitespace
>    drm/i915: Improve PPS debugs
> 
>   drivers/gpu/drm/i915/display/icl_dsi.c        |   2 +-
>   drivers/gpu/drm/i915/display/intel_bios.c     |  56 ++-
>   drivers/gpu/drm/i915/display/intel_bios.h     |  11 +-
>   .../gpu/drm/i915/display/intel_connector.c    |   2 +-
>   .../drm/i915/display/intel_display_types.h    |  24 +-
>   drivers/gpu/drm/i915/display/intel_dp.c       |  19 +-
>   drivers/gpu/drm/i915/display/intel_lvds.c     |   4 +-
>   drivers/gpu/drm/i915/display/intel_panel.c    |   9 +
>   drivers/gpu/drm/i915/display/intel_panel.h    |   1 +
>   drivers/gpu/drm/i915/display/intel_pps.c      | 360 +++++++++++++-----
>   drivers/gpu/drm/i915/display/intel_pps.h      |   2 +-
>   drivers/gpu/drm/i915/display/intel_sdvo.c     |   2 +-
>   drivers/gpu/drm/i915/display/vlv_dsi.c        |   2 +-
>   drivers/gpu/drm/i915/i915_reg.h               |   1 +
>   14 files changed, 364 insertions(+), 131 deletions(-)
> 


Acked-by: Tim Gardner <tim.gardner at canonical.com>

All clean cherry picks
-- 
-----------
Tim Gardner
Canonical, Inc