ACK/Cmnt: [SRU][J:linux-bluefield][Pull Request] mlxbf_gige: need to replace SAUCE patches with upstream commits

Tim Gardner tim.gardner at canonical.com
Fri Mar 24 13:21:10 UTC 2023


On 3/23/23 2:34 PM, David Thompson wrote:
> The GIGE driver ("mlxbf_gige") in the Jammy repo contains SAUCE
> patches that enable BlueField-3 support. This same functionality
> is contained in upstream commits and Jammy repo should utilize them.
> 
> This pull request reverts 6 SAUCE commits, replacing them with 4
> upstream commits. Note: two of the reverted SAUCE commits were not
> replaced with upstream commits, as those changes are not needed.
> 
> BugLink: https://bugs.launchpad.net/bugs/2012649
> 
> Testing
> - Successful boot of kernel on BlueField-2 and BlueField-3 platforms
> - Bring up "oob_net0" interface and pass traffic tests
> - Restart auto-negotiation on "oob_net0" link, interface up, passes traffic
> 
> The pull request page can be found at:
>    https://code.launchpad.net/~dthompso-98/ubuntu/+source/linux-bluefield/+git/linux-bluefield/+merge/439526
> 
> Git repo can be found at:
>    git://git.launchpad.net/~dthompso-98/ubuntu/+source/linux-bluefield/+git/jammy mlxbf_gige_bf3
> 
> for you to fetch starting from commit 58759cc4d49346a967bc960df600a4f99d71c3d1
>    "UBUNTU: Ubuntu-bluefield-5.15.0-1014.16"
> 
> Signed-off-by: David Thompson <davthompson at nvidia.com>
> 
> David Thompson (10):
>    Revert "UBUNTU: SAUCE: mlxbf_gige: add BlueField-3 ethtool_ops"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: add BlueField-3 Serdes configuration"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: support 10M/100M/1G speeds on BlueField-3"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: add MDIO support for BlueField-3"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: set driver version to 1.27"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: add validation of ACPI table version"
>    mlxbf_gige: add MDIO support for BlueField-3
>    mlxbf_gige: support 10M/100M/1G speeds on BlueField-3
>    mlxbf_gige: add "set_link_ksettings" ethtool callback
>    mlxbf_gige: fix white space in mlxbf_gige_eth_ioctl
> 
>   .../net/ethernet/mellanox/mlxbf_gige/Makefile |    3 +-
>   .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h |    7 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  |   16 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_main.c     |   68 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_mdio.c     |   37 +
>   .../mellanox/mlxbf_gige/mlxbf_gige_uphy.c     | 1191 -----------------
>   .../mellanox/mlxbf_gige/mlxbf_gige_uphy.h     |  398 ------
>   7 files changed, 48 insertions(+), 1672 deletions(-)
>   delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_uphy.c
>   delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_uphy.h
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

I could not get the branch from 
'git://git.launchpad.net/~dthompso-98/ubuntu/+source/linux-bluefield/+git/jammy 
mlxbf_gige_bf3', but was able to figure it out from the LP pull request 
page. Must be something with LaunchPad.
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list