ACK/Cmnt: [SRU][J:linux-bluefield][PATCH v2 0/4] UBUNTU: SAUCE: mlxbf-ptm: add atx debugfs nodes

[Tim Gardner]

On 3/22/23 9:39 AM, Jitendra Lanka wrote:
> BugLink: https://bugs.launchpad.net/bugs/2011738
> 
> SRU Justification:
> 
> [Impact]
> 
> mlxbf-ptm is a kernel driver that provides debufgs interface for system
> software to monitor Bluefield devices' power and thermal management
> parameters.
> 
> [Fix]
> 
> This change:
> * Updates the license
> * Replaces S_IRUGO with 0444 inline with checkpatch expectation.
> * adds additional debugfs nodes that provide ATX status and
>    power profile data.
> * Increments module version
> 
> [Test Case]
> 
> * After installing the kernel module, debugfs entry at
>    /sys/kernel/debug/mlxbf-ptm will be created
> * monitors/status folder contains read-only parameters reported from the
>    Bluefield device
> 
> [Regression Potential]
> 
> * Minimal - as these are read-only parameters that report Bluefield device
>    information.
> 
> [Other]
> * This code is likely to change depending on feedback we received from
>    maintainers.
> 
> Jitendra Lanka (4):
>    UBUNTU: SAUCE: mlxbf-ptm: update license
>    UBUNTU: SAUCE: mlxbf-ptm: use 0444 instead of S_IRUGO
>    UBUNTU: SAUCE: mlxbf-ptm: add atx debugfs nodes
>    UBUNTU: SAUCE: mlxbf-ptm: update module version
> 
>   drivers/platform/mellanox/mlxbf-ptm.c | 86 ++++++++++++++++-----------
>   1 file changed, 50 insertions(+), 36 deletions(-)
> 

Incidentally, I don't really agree with checkpatch on this one. I think 
the macro is more readable then octal numbers.
-- 
-----------
Tim Gardner
Canonical, Inc