ACK/Cmnt: [SRU][PULL][Jammy:linux-intel-iotg] Revert out-of-tree patches that causes system hang after running veth.sh kernel selftest

[Jian Hui Lee]

On Wed, Mar 22, 2023 at 1:39 AM Tim Gardner <tim.gardner at canonical.com> wrote:
>
> On 3/15/23 1:00 AM, Jian Hui Lee wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2008085
> >
> > [Impact]
> >
> > System would be hang after running veth.sh from kernel selftests.
> >
> > [Test Plan]
> >
> > Prepare the testing environment, especially bpf selftest, and run
> > veth.sh with root privilege. The test case should be finished without
> > any problems.
> >
> > [Regression potential]
> >
> > Low. The reverted patches are from Intel Out-Of-Tree.
> >
> > [Other info]
> >
> > https://git.launchpad.net/~jianhuilee/ubuntu/+source/linux-intel-iotg/+git/jammy-iotg/log/?h=for-review-20230314
> > The issue is caused by "net/core: XDP metadata BTF netlink API" and
> > the rest are the patches around it.
> >
> >
> > ----------------------------------------------------------------
> > The following changes since commit f101bab14a2fbc73c8bd99934c005ffa974b5236:
> >
> >    UBUNTU: Ubuntu-intel-iotg-5.15.0-1027.32 (2023-03-02 12:36:02 -0500)
> >
> > are available in the Git repository at:
> >
> >    git://git.launchpad.net/~jianhuilee/ubuntu/+source/linux-intel-iotg/+git/jammy-iotg
> > for-review-20230314
> >
> > for you to fetch changes up to 23d954e07c7a7b8429ab56f7ffa2e2a6d9a2de1a:
> >
> >    Revert "net/core: XDP metadata BTF netlink API" (2023-03-15 11:37:47 +0800)
> >
> > ----------------------------------------------------------------
> > Jian Hui Lee (5):
> >        Revert "rtnetlink: Add return value check"
> >        Revert "rtnetlink: Fix unchecked return value of dev_xdp_query_md_btf()"
> >        Revert "igc: Enable HW RX Timestamp for AF_XDP ZC"
> >        Revert "igc: Add BTF based metadata for XDP"
> >        Revert "net/core: XDP metadata BTF netlink API"
> >
> >   drivers/net/ethernet/intel/igc/igc.h      |   2 -
> >   drivers/net/ethernet/intel/igc/igc_main.c |  21 ------
> >   drivers/net/ethernet/intel/igc/igc_xdp.c  | 114 ------------------------------
> >   drivers/net/ethernet/intel/igc/igc_xdp.h  |  11 ---
> >   include/linux/netdevice.h                 |  15 +---
> >   include/uapi/linux/if_link.h              |   2 -
> >   net/core/dev.c                            |  53 --------------
> >   net/core/rtnetlink.c                      |  25 +------
> >   8 files changed, 2 insertions(+), 241 deletions(-)
> >
> Acked-by: Tim Gardner <tim.gardner at canonical.com>
>
> Have you noticed other test failures once XDP support has been removed ?

i did not notice any other network failures after reverting. the
removed feature is used in intel igc driver for exporting extra meta
data, like timestamp. xdp support is not affected.

-- 
Best,
Jian Hui Lee