ACK: [B][SRU][PATCH 0/1] selftests/ftrace: Fix bash specific "==" operator

Tim Gardner tim.gardner at canonical.com
Tue Mar 21 18:21:25 UTC 2023


On 3/21/23 1:15 AM, Po-Hsu Lin wrote:
> == Impact ==
> With upstream commit a1d6cd88c "selftests/ftrace: event_triggers: wait
> longer for test_event_enable" applied via stable update, ftrace in
> Bionic proposed (4.15.0-207.218) is now failing with:
> 
> $ sudo ./ftracetest ./test.d/ftrace/func_event_triggers.tc
> [1] ftrace - test for function event triggers [FAIL]
> [2] (instance) ftrace - test for function event triggers [FAIL]
> 
> With -v added to the command you will see it failing with:
> ./ftracetest: 52: [: 0: unexpected operator
> 
> The "==" operator fix from 1e6b485c can solve this problem.
> 
> == Fix ==
> * 1e6b485c selftests/ftrace: Fix bash specific "==" operator
> 
> This patch can be cherry-picked into Bionic. We have this fix in other
> kernels already.
> 
> == Testcase ==
> Running the kernel selftests/ftracetest with -v flag, it should no
> longer show these two "test for function event triggers" test FAIL
> because of this unexpected operator issue.
> 
> == Regression Potential ==
> This affects only the selftest suite and only ftrace subtests. Any
> change would only be observable there.
> 
> Masami Hiramatsu (Google) (1):
>    selftests/ftrace: Fix bash specific "==" operator
> 
>   tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list