APPLIED[L]: [lunar:linux][lunar:linux-unstable][PATCH v2 1/3] UBUNTU: [Packaging] Support skipped dkms modules

[Andrea Righi]

On Thu, Mar 09, 2023 at 02:13:58PM +0000, Dimitri John Ledkov wrote:
...
> > >  define build_dkms =
> > > -     ARCH=$(build_arch) CROSS_COMPILE=$(CROSS_COMPILE) $(SHELL) $(DROOT)/scripts/dkms-build $(dkms_dir) $(abi_release)-$* '$(call build_dkms_sign,$(builddir)/build-$*)' $(1) $(2) $(3) $(4) $(5)
> > > +     rc=0; ARCH=$(build_arch) CROSS_COMPILE=$(CROSS_COMPILE) $(SHELL) $(DROOT)/scripts/dkms-build $(dkms_dir) $(abi_release)-$* '$(call build_dkms_sign,$(builddir)/build-$*)' $(1) $(2) $(3) $(4) $(5) || rc=$$?; if [ "$$rc" = "9" ]; then echo do_$(4)_$*=false >> $(builddir)/skipped-dkms.mk; rc=0; fi; if [ "$$rc" != "0" ]; then exit $$rc; fi
> >
> > What does rc==9 mean? It seems to be the "skip case, right? Maybe a
> > little comment here explaining the meaning of this special value would
> > be helpful.
> >
> 
> In our case it is:
> 
> # Error out if build_exclude is set
>     [[ $build_exclude ]] && die 9 \
>         $"The $base_dir/dkms.conf for module $module includes a
> BUILD_EXCLUSIVE directive which does not match this
> kernel/arch/config."\
>         $"This indicates that it should not be built."
> 
> However, exit code 9 can have other meanings too, w.r.t. missing
> dkms.conf and permissions when making precompiled tarballs. I think
> this is ok for now, but i will contact upstream about making error
> codes unique / fixed.

OK, looks good for now, thanks for the clarification. Applied to
lunar/linux.

-Andrea