NACK/Cmnt: [SRU][J:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: mlxbf-gige: Fix intermittent no ip issue

[Stefan Bader]

On 01.03.23 00:03, Asmaa Mnebhi wrote:
> BugLink: https://bugs.launchpad.net/bugs/2008833
> 
> SRU Justification:
> 
> [Impact]
> 
> Although the link is up, and the PHY interrupt is cleared, there is no ip assigned.
> Nothing is being transmitted, and nothing is received. The RX error count keeps on
> increasing (check ifconfig oob_net0). After several minutes, the RX error count
> stagnates and the oob finally gets an ip and is pingable.
> 
> [Fix]
> 
> The issue is in the mlxbf_gige_rx_init function. As soon as the RX DMA is enabled,
> the RX CI reaches the max 128, it becomes equal to RX PI. And RX CI doesn't decrease
> since the code hasn't ran phy_start yet. The solution is to move the rx init after
> phy_start. This fix applies to both 5.4 and 5.15.
> 
> [Test Case]
> 
> * Check if the gige driver is loaded
> * Check that the oob_net0 interface is up and pingable from an external host
> * Do at ~1000 resets and powercycles and check the oon_net0 interface again
> 
> [Regression Potential]
> 
> * No known regressions.
> 
> Asmaa Mnebhi (1):
>    UBUNTU: SAUCE: mlxbf-gige: Fix intermittent no ip issue
> 
>   .../ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 14 +++++++-------
>   .../ethernet/mellanox/mlxbf_gige/mlxbf_gige_rx.c   |  6 +++---
>   2 files changed, 10 insertions(+), 10 deletions(-)
> 

There is an identical submission one minute later.

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230301/64f6d0d9/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230301/64f6d0d9/attachment-0001.sig>