NACK: [Patch][UC22] Add firmware files for Atheros bluetooth modules

[Juerg Haefliger]

On Tue, 27 Jun 2023 10:24:00 +0200
Sergio Costas <sergio.costas at canonical.com> wrote:

> BugLink: https://bugs.launchpad.net/ubuntu/+bug/2025054
> 
> When using the Ubuntu Core 22 kernel in an Asus Zenbook UX21, this error 
> is shown in journalctl:
> 
>          usb 1-1-1: Direct firmware load for ar3k/AthrBT_0x01020200.dfu 
> failed with error -2
>          Bluetooth: Patch file not found ar3k/AthrBT_0x01020200.dfu
>          Bluetooth: Loading patch file failed
>          ath3k: probe of 1-1.1:1.0 failed with error -2
> 
> Also, the bluetooth module doesn't work. This is because the current 
> PC-KERNEL snap used in Ubuntu Core/Ubuntu Core Desktop (UC22) lacks the 
> Atheros AR3K firmware files, which means that devices with an Atheros 
> Bluetooth device (like the specified Asus Zenbook UX21) won't be able to 
> use it.
> 
> This patch adds the missing files.

1) Please no attachments (best to use git format-patch and git
send-email).
2) Your patch blindly copies the ar3k files regardless of whether
they're actually used or not. The script is used by multiple/different
kernels (pc, pi, intel-iotg). Hm, the kernel doesn't reference the ar3k files
(I tried to fix that upstream but it was rejected) so you need to copy the
ar3k files based on the presence of the ath3k module.
3) Please add an LP bug reference to the comment in the patch.

...JUerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230629/962edfcb/attachment-0001.sig>