ACK/Cmnt: [PATCH v1 0/1] [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: mlxbf-tmfifo: fix potential race

Tim Gardner tim.gardner at canonical.com
Thu Jun 22 15:34:32 UTC 2023


On 6/22/23 7:06 AM, Liming Sun wrote:
> BugLink: https://bugs.launchpad.net/bugs/2016039
> 
> SRU Justification:
> 
> [Impact]
> This commit is ported from Jammy repo (commit eeeee955aefe).
> This change is needed to avoid potential race of accessing the 'vq' pointer
> 
> [Fix]
> The fix adds memory barrier for the is_ready flag and the 'vq' pointer access in mlxbf_tmfifo_virtio_find_vqs(), so updated in vq will be visible before accessing this pointer.
> 
> [Test Case]
> Same functionality and testing as on BlueField-1/2/3. No functionality change.
> 
> [Regression Potential]
> Same behavior from user perspective
> 
> Liming Sun (1):
>    UBUNTU: SAUCE: mlxbf-tmfifo: fix potential race
> 
>   drivers/platform/mellanox/mlxbf-tmfifo.c | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

 From the Jammy patch: [bzolnier: this patch also contains a fix for 
mlxbf_tmfifo_create_vdev() failure case]

-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list