NACK: [SRU][PULL v2][linux-firmware][J/K/L] Add firmware files for HP G10 series laptops

Juerg Haefliger juerg.haefliger at canonical.com
Wed Jun 21 10:18:07 UTC 2023


Does not apply cleanly to Jammy and Kinetic. And after applying to Lunar:

$ make check
E: cirrus/cs35l41-dsp1-spk-cali-17aa2316-spkid0-l0.bin listed in WHENCE or WHENCE.ubuntu does not exist
E: cirrus/cs35l41-dsp1-spk-cali-17aa2316-spkid0-r0.bin listed in WHENCE or WHENCE.ubuntu does not exist
E: cirrus/cs35l41-dsp1-spk-cali-17aa2316-spkid1-l0.bin listed in WHENCE or WHENCE.ubuntu does not exist
E: cirrus/cs35l41-dsp1-spk-cali-17aa2316-spkid1-r0.bin listed in WHENCE or WHENCE.ubuntu does not exist
E: cirrus/cs35l41-dsp1-spk-prot-17aa2316-spkid0-l0.bin listed in WHENCE or WHENCE.ubuntu does not exist
E: cirrus/cs35l41-dsp1-spk-prot-17aa2316-spkid0-r0.bin listed in WHENCE or WHENCE.ubuntu does not exist
E: cirrus/cs35l41-dsp1-spk-prot-17aa2316-spkid1-l0.bin listed in WHENCE or WHENCE.ubuntu does not exist
E: cirrus/cs35l41-dsp1-spk-prot-17aa2316-spkid1-r0.bin listed in WHENCE or WHENCE.ubuntu does not exist
make: *** [Makefile:9: check] Error 1


...Juerg


> BugLink: https://bugs.launchpad.net/bugs/2023193
> 
> [ Impact ]
> HP G10 laptops need more Cirrus firmware files to enable all amplifiers to output audio with expected level.
> 
> [ Test Plan ]
>  * Power up the HP G10 series laptops and adjust the output volume to MAX
>  * Verify speaker output volume by ears.
> 
> [ Where problems could occur ]
>  * The firmware files are released by Cirrus codec for particular HP series laptops.
>  * The risk of regression should only impact particular models
> 
> V2: add BugLink to the commit and exclude binary diffs in the PR
> 
> ----------------------------------------------------------------
> The following changes since commit 1a02435c159a00ef79513f0ef826311fe86c916c:
> 
>   UBUNTU: Ubuntu-20230323.gitbcdcfbcf-0ubuntu1.2 (2023-06-05 09:22:50 +0200)
> 
> are available in the Git repository at:
> 
>   git+ssh://git.launchpad.net/~mschiu77/ubuntu/+source/linux-firmware lp2019213
> 
> for you to fetch changes up to 1bceedd68f49b84cadb777289aacf515470691d4:
> 
>   cirrus: Add firmware and tuning files for HP G10 series laptops (2023-06-07 19:08:36 +0800)
> 
> ----------------------------------------------------------------
> Vitaly Rodionov (1):
>       cirrus: Add firmware and tuning files for HP G10 series laptops
> 
>  WHENCE                                       | 104 +++++++++++++++++++++++++++
>  cirrus/cs35l41-dsp1-spk-cali-103c8b42.bin    | Bin 0 -> 1868 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b43.bin    | Bin 0 -> 1892 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b44.bin    | Bin 0 -> 1884 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b45.bin    | Bin 0 -> 1868 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b47.bin    | Bin 0 -> 1888 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b63-l0.bin | Bin 0 -> 1964 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b63-l1.bin | Bin 0 -> 1968 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b63-r0.bin | Bin 0 -> 1964 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b63-r1.bin | Bin 0 -> 1968 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b8f-r0.bin | Bin 0 -> 1952 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b8f-r1.bin | Bin 0 -> 1952 bytes
>  cirrus/cs35l41-dsp1-spk-cali-103c8b92.bin    | Bin 0 -> 1856 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b42.bin    | Bin 0 -> 4816 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b43.bin    | Bin 0 -> 4840 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b44.bin    | Bin 0 -> 4928 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b45.bin    | Bin 0 -> 4820 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b47.bin    | Bin 0 -> 4920 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b63-l0.bin | Bin 0 -> 5408 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b63-l1.bin | Bin 0 -> 5448 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b63-r0.bin | Bin 0 -> 5408 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b63-r1.bin | Bin 0 -> 5448 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b8f-r0.bin | Bin 0 -> 5416 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b8f-r1.bin | Bin 0 -> 5388 bytes
>  cirrus/cs35l41-dsp1-spk-prot-103c8b92.bin    | Bin 0 -> 4816 bytes
>  25 files changed, 104 insertions(+)
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b42.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b43.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b44.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b45.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b47.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b63-l0.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b63-l1.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b63-r0.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b63-r1.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b8f-r0.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b8f-r1.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-cali-103c8b92.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b42.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b43.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b44.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b45.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b47.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b63-l0.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b63-l1.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b63-r0.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b63-r1.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b8f-r0.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b8f-r1.bin
>  create mode 100644 cirrus/cs35l41-dsp1-spk-prot-103c8b92.bin
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230621/a3b7a803/attachment.sig>


More information about the kernel-team mailing list