ACK: [mantic][PATCH] UBUNTU: [Config] Add CONFIG_AS_HAS_NON_CONST_LEB128 on riscv64

[Tim Gardner]

On 6/13/23 05:05, Andrea Righi wrote:
> On Tue, Jun 13, 2023 at 11:31:12AM +0100, Dimitri John Ledkov wrote:
>> riscv64 now too has CONFIG_AS_HAS_NON_CONST_LEB128 available.
>>
>> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
>> ---
> 
> It looks like a change that has been introduced with binutils >= 2.40.50
> (also as a reference https://sourceware.org/bugzilla/show_bug.cgi?id=27215).
> 
> I'd change the description a little bit and update also AS_VERSION and
> LD_VERSION to make it clear that it's config diff caused by a toolchain
> change, something like the following.
> 
> What do you think?
> 
> ---
> 
> From: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
> 
> UBUNTU: [Config] Add CONFIG_AS_HAS_NON_CONST_LEB128 on riscv64
> 
> riscv64 now too has CONFIG_AS_HAS_NON_CONST_LEB128 available with the
> new binutils (>= 2.40.50).
> 
> Moreover, update AS_VERSION and LD_VERSION.
> 
> Link: https://sourceware.org/bugzilla/show_bug.cgi?id=27215
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
> Signed-off-by: Andrea Righi <andrea.righi at canonical.com>
> 
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index f15dd4ce26ef..665e1e3c00b0 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -1755,13 +1755,13 @@ CONFIG_AS_HAS_CFI_NEGATE_RA_STATE               policy<{'arm64': 'y'}>
>   CONFIG_AS_HAS_INSN                              policy<{'riscv64': 'y'}>
>   CONFIG_AS_HAS_LDAPR                             policy<{'arm64': 'y'}>
>   CONFIG_AS_HAS_LSE_ATOMICS                       policy<{'arm64': 'y'}>
> -CONFIG_AS_HAS_NON_CONST_LEB128                  policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> +CONFIG_AS_HAS_NON_CONST_LEB128                  policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>
>   CONFIG_AS_HAS_SHA3                              policy<{'arm64': 'y'}>
>   CONFIG_AS_IS_GNU                                policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>
>   CONFIG_AS_SHA1_NI                               policy<{'amd64': 'y'}>
>   CONFIG_AS_SHA256_NI                             policy<{'amd64': 'y'}>
>   CONFIG_AS_TPAUSE                                policy<{'amd64': 'y'}>
> -CONFIG_AS_VERSION                               policy<{'amd64': '24000', 'arm64': '24000', 'armhf': '24000', 'ppc64el': '24000', 'riscv64': '24000', 's390x': '24000'}>
> +CONFIG_AS_VERSION                               policy<{'amd64': '24050', 'arm64': '24050', 'armhf': '24050', 'ppc64el': '24050', 'riscv64': '24050', 's390x': '24050'}>
>   CONFIG_AS_VFP_VMRS_FPINST                       policy<{'armhf': 'y'}>
>   CONFIG_AT76C50X_USB                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm'}>
>   CONFIG_AT803X_PHY                               policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm', 's390x': '-'}>
> @@ -7048,7 +7048,7 @@ CONFIG_LD_HEAD_STUB_CATCH                       policy<{'ppc64el': 'n'}>
>   CONFIG_LD_IS_BFD                                policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>
>   CONFIG_LD_ORPHAN_WARN                           policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y'}>
>   CONFIG_LD_ORPHAN_WARN_LEVEL                     policy<{'amd64': '"warn"', 'arm64': '"warn"', 'armhf': '"warn"', 'ppc64el': '"warn"', 'riscv64': '"warn"'}>
> -CONFIG_LD_VERSION                               policy<{'amd64': '24000', 'arm64': '24000', 'armhf': '24000', 'ppc64el': '24000', 'riscv64': '24000', 's390x': '24000'}>
> +CONFIG_LD_VERSION                               policy<{'amd64': '24050', 'arm64': '24050', 'armhf': '24050', 'ppc64el': '24050', 'riscv64': '24050', 's390x': '24050'}>
>   CONFIG_LEDS_88PM860X                            policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm', 's390x': '-'}>
>   CONFIG_LEDS_AAEON                               policy<{'amd64': 'm'}>
>   CONFIG_LEDS_AAT1290                             policy<{'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm'}>
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>
-- 
-----------
Tim Gardner
Canonical, Inc