[SRU][K][PATCH 2/6] sbitmap: remove unnecessary code in __sbitmap_queue_get_batch
Gerald Yang
gerald.yang at canonical.com
Tue Jun 6 10:28:24 UTC 2023
From: Liu Song <liusong at linux.alibaba.com>
BugLink: https://bugs.launchpad.net/bugs/2022318
If "nr + nr_tags <= map_depth", then the value of nr_tags will not be
greater than map_depth, so no additional comparison is required.
Signed-off-by: Liu Song <liusong at linux.alibaba.com>
Link: https://lore.kernel.org/r/1661483653-27326-1-git-send-email-liusong@linux.alibaba.com
Signed-off-by: Jens Axboe <axboe at kernel.dk>
(cherry picked from commit ddbfc34fcf5d0bc33b006b90c580c56edeb31068)
Signed-off-by: Gerald Yang <gerald.yang at canonical.com>
---
lib/sbitmap.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/sbitmap.c b/lib/sbitmap.c
index 1f31147872e6..a39b1a877366 100644
--- a/lib/sbitmap.c
+++ b/lib/sbitmap.c
@@ -533,10 +533,9 @@ unsigned long __sbitmap_queue_get_batch(struct sbitmap_queue *sbq, int nr_tags,
nr = find_first_zero_bit(&map->word, map_depth);
if (nr + nr_tags <= map_depth) {
atomic_long_t *ptr = (atomic_long_t *) &map->word;
- int map_tags = min_t(int, nr_tags, map_depth);
unsigned long val, ret;
- get_mask = ((1UL << map_tags) - 1) << nr;
+ get_mask = ((1UL << nr_tags) - 1) << nr;
do {
val = READ_ONCE(map->word);
if ((val & ~get_mask) != val)
@@ -547,7 +546,7 @@ unsigned long __sbitmap_queue_get_batch(struct sbitmap_queue *sbq, int nr_tags,
if (get_mask) {
*offset = nr + (index << sb->shift);
update_alloc_hint_after_get(sb, depth, hint,
- *offset + map_tags - 1);
+ *offset + nr_tags - 1);
return get_mask;
}
}
--
2.25.1
More information about the kernel-team
mailing list