NACK/Cmnt: [PATCH 0/2] [SRU][J:linux-bluefield][PATCH v1 0/2] UBUNTU: SAUCE: mlxbf-tmfifo: robust fix to drop over-sized packet or no Rx descriptors

[Stefan Bader]

On 30.05.23 16:30, Liming Sun wrote:
> BugLink: https://bugs.launchpad.net/bugs/2021749
> 
> SRU Justification:
> 
> [Impact]
> This change is needed to avoid potential tmfifo console stuck when
> network interface is down or receiving oversized packets.
> 
> [Fix]
> Drop the Rx packets in the above cases. Since tmfifo is shared
> resource for both console and networking. Dropping such network
> packets can continue to process the fifo and avoid console stuck.
> 
> [Test Case]
> Same functionality and testing as on BlueField-1/2/3. No functionality
> change. Add negative tests:
> - 'ifconfig tmfifo_net0 down' on ARM side during traffic, then verify
>    rshim console doesn't stuck.
> - Config MTU to 4000 on rshim host and send oversized packet with command
>    'ping 192.168.100.2 -s 2000". It shouldn't cause any stuck.
> 
> [Regression Potential]
> Same behavior from user perspective.
> 
> Liming Sun (2):
>    mlxbf-tmfifo: Drop the Rx packet if no more descriptors
>    mlxbf-tmfifo: Drop jumbo frames
> 
>   drivers/platform/mellanox/mlxbf-tmfifo.c | 88 +++++++++++++++++-------
>   1 file changed, 62 insertions(+), 26 deletions(-)
> 

Rejected for the following reasons:
There seems to be a v2 of this which is already pending application.

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230606/447e3e1e/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230606/447e3e1e/attachment-0001.sig>