ACK/Cmnt: [SRU][F:linux-bluefield][PATCH v1 0/1] mlxbf-gige: Fix intermittent no ip issue

[Tim Gardner]

On 6/2/23 1:47 PM, Asmaa Mnebhi wrote:
> BugLink: https://bugs.launchpad.net/bugs/2022387
> 
> SRU Justification:
> 
> [Impact]
> 
> Although the link is up, and the PHY interrupt is cleared, there is no ip assigned. Nothing is being transmitted, and nothing is received. The RX error count keeps on increasing (check ifconfig oob_net0). After several minutes, the RX error count stagnates and the oob finally gets an ip and is pingable.
> 
> [Fix]
> 
> The issue is in the mlxbf_gige_rx_init function. As soon as the RX DMA is enabled,
> the RX CI reaches the max 128, it becomes equal to RX PI. And RX CI doesn't decrease
> since the code hasn't ran phy_start yet. The solution is to move the rx init after phy_start.
> 
> [Test Case]
> 
> * Check if the gige driver is loaded
> * Check that the oob_net0 interface is up and pingable from an external host
> * Do at ~1000 resets and powercycles and check the oon_net0 interface again
> 
> [Regression Potential]
> 
> * No known regressions.
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

This should be a SAUCE patch until it gets upstream.
-- 
-----------
Tim Gardner
Canonical, Inc