[PATCH 0/6 V2][SRU][Lunar] Fix only reach PC3 when ethernet is plugged r8169
Koba Ko
koba.ko at canonical.com
Mon Jun 5 03:27:05 UTC 2023
BugLink: https://bugs.launchpad.net/bugs/1946433
[impact]
Restrictions on enabling ASPM prevented power savings when the network is not fully loaded.
Keeping ASPM enabled during NAPI poll can cause issues
like rx_missed errors or tx timeouts on some chip versions.
The root causes of these issues are unknown.
[fix]
- Remove unnecessary ASPM restrictions to allow enabling ASPM more often, increasing power savings.
- Disable ASPM during NAPI poll to avoid issues on some chip versions.
[test cases]
1. don't ping or make data transacation through ethernet.
2. check /sys/kernel/debug/pmc_core_package_cstate_show
[where the issue could happen]
low, this increases both performance and stablility.
[Misc]
All patches landed on unstable.
~~~
V2: SRUed the cleaner version that have landsed on vanilla kernel.
Heiner Kallweit (6):
r8169: use spinlock to protect mac ocp register access
r8169: use spinlock to protect access to registers Config2 and Config5
r8169: enable cfg9346 config register access in atomic context
r8169: prepare rtl_hw_aspm_clkreq_enable for usage in atomic context
r8169: disable ASPM during NAPI poll
r8169: remove ASPM restrictions now that ASPM is disabled during NAPI
poll
drivers/net/ethernet/realtek/r8169_main.c | 145 +++++++++++++++-------
1 file changed, 100 insertions(+), 45 deletions(-)
--
2.25.1
More information about the kernel-team
mailing list