ACK: [PATCH v2 0/1] [SRU][J:linux-bluefield][PATCH v2 0/1] UBUNTU: SAUCE: mlxbf-tmfifo: fix potential race
Bartlomiej Zolnierkiewicz
bartlomiej.zolnierkiewicz at canonical.com
Fri Jun 2 11:53:07 UTC 2023
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>
Since the patch is small and info about mlxbf_tmfifo_create_vdev()
failure case fix can be added while applying it I've reluctantly
ACK-ed it as it is. However please next time use separate patches for
unrelated changes.
On Thu, Apr 13, 2023 at 2:33 PM Liming Sun <limings at nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2016039
>
> SRU Justification:
>
> [Impact]
> This change is needed to avoid potential race of accessing the 'vq' pointer
>
> [Fix]
> The fix adds memory barrier for the is_ready flag and the 'vq' pointer access in mlxbf_tmfifo_virtio_find_vqs(), so updated in vq will be visible before accessing this pointer.
>
> [Test Case]
> Same functionality and testing as on BlueField-1/2/3. No functionality change.
>
> [Regression Potential]
> Same behavior from user perspective
>
> Liming Sun (1):
> mlxbf-tmfifo: fix potential race
>
> drivers/platform/mellanox/mlxbf-tmfifo.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
More information about the kernel-team
mailing list