[SRU][K:master-next][PATCH v2 2/2] pktcdvd: check for NULL returna fter calling bio_split_to_limits()

[Aleksandr Mikhalitsyn]

On Thu, Jun 1, 2023 at 10:56 AM Andrea Righi <andrea.righi at canonical.com> wrote:
>
> On Thu, Jun 01, 2023 at 10:27:05AM +0200, Alexander Mikhalitsyn wrote:
> > From: Jens Axboe <axboe at kernel.dk>
> >
> > BugLink: https://bugs.launchpad.net/bugs/2020901
>
> Is this a private bug? I can't see it.

Ah, yep. We've decided to make it public.

>
> >
> > commit 3e9900f3bd7ba30d60f82b162b70a1dffe4e8e24 upstream.
>
> ^ You can drop this line, see below.

Fixed.

>
> >
> > The revert of the removal of this driver happened after we fixed up
> > the split limits for NOWAIT issue, hence it got missed. Ensure that
> > we check for a NULL bio after splitting, in case it should be retried.
> >
> > Marking this as fixing both commits, so that stable backport will do
> > this correctly.
> >
> > Cc: stable at vger.kernel.org
> > Fixes: 9cea62b2cbab ("block: don't allow splitting of a REQ_NOWAIT bio")
> > Fixes: 4b83e99ee709 ("Revert "pktcdvd: remove driver."")
> > Signed-off-by: Jens Axboe <axboe at kernel.dk>
> > [amikhalitsyn: adjust context bio_split_to_limits -> blk_queue_split]
>
> The proper syntax here would be:
>
> (backported from 3e9900f3bd7ba30d60f82b162b70a1dffe4e8e24)
> [amikhalitsyn: adjust context bio_split_to_limits -> blk_queue_split]
>
> Or if you don't have to do any change (or very minimal changes):
>
> (cherry-picked from 3e9900f3bd7ba30d60f82b162b70a1dffe4e8e24)

Fixed.

Thanks,
Alex
>
> > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn at canonical.com>
> > ---
>
> -Andrea