[JAMMY][PATCH v2 1/3] firmware_loader: EXTRA_FIRMWARE does not support compressed files

Dimitri John Ledkov dimitri.ledkov at canonical.com
Thu Jul 27 16:31:22 UTC 2023


From: Randy Dunlap <rdunlap at infradead.org>

Document in the firmware loader Kconfig help text that firmware image
file compression is not supported for builtin EXTRA_FIRMWARE files so
that someone does not waste time trying that.

Cc: Luis Chamberlain <mcgrof at kernel.org>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael at kernel.org>
Acked-by: Luis Chamberlain <mcgrof at kernel.org>
Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
Link: https://lore.kernel.org/r/20220214222311.9758-1-rdunlap@infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
(cherry picked from commit 36744c117ab4e3d7e114c10d66882c418ba6ea8a)
BugLink: https://bugs.launchpad.net/bugs/2028550
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
---
 drivers/base/firmware_loader/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/base/firmware_loader/Kconfig b/drivers/base/firmware_loader/Kconfig
index 5b24f39592..38f3b66bf5 100644
--- a/drivers/base/firmware_loader/Kconfig
+++ b/drivers/base/firmware_loader/Kconfig
@@ -60,6 +60,8 @@ config EXTRA_FIRMWARE
 	  image since it combines both GPL and non-GPL work. You should
 	  consult a lawyer of your own before distributing such an image.
 
+	  NOTE: Compressed files are not supported in EXTRA_FIRMWARE.
+
 config EXTRA_FIRMWARE_DIR
 	string "Firmware blobs root directory"
 	depends on EXTRA_FIRMWARE != ""
@@ -169,6 +171,9 @@ config FW_LOADER_COMPRESS
 	  be compressed with either none or crc32 integrity check type (pass
 	  "-C crc32" option to xz command).
 
+	  Compressed firmware support does not apply to firmware images
+	  that are built into the kernel image (CONFIG_EXTRA_FIRMWARE).
+
 config FW_CACHE
 	bool "Enable firmware caching during suspend"
 	depends on PM_SLEEP
-- 
2.34.1




More information about the kernel-team mailing list