[focal][PATCH] builddeb: allow selection of .deb compressor

[Masahiro Yamada]

On Mon, Jul 24, 2023 at 11:32 PM Dimitri John Ledkov
<dimitri.ledkov at canonical.com> wrote:
>
> Hi,
>
> On Mon, 24 Jul 2023 at 09:24, Masahiro Yamada
> <masahiro.yamada at canonical.com> wrote:
> >
> > From: Michał Mirosław <mirq-linux at rere.qmqm.pl>
> >
> > [ Upstream commit 1a7f0a34ea7d05d1ffcd32c9b1b4e07ac0687538 ]
> >
> > Select deb compression using KDEB_COMPRESS make variable. This allows to
> > use gzip compression for local or test builds, and that's way faster
> > than now-default xz compression.
> >
> > Signed-off-by: Michał Mirosław <mirq-linux at rere.qmqm.pl>
> > Signed-off-by: Masahiro Yamada <masahiroy at kernel.org>
> > Signed-off-by: Masahiro Yamada <masahiro.yamada at canonical.com>
> > ---
> >
> > This is not a bug-fix, but this is useful to speed-up 'make bindeb-pkg'.
> >
>
> However in Ubuntu, we don't use this ever, and should not be using it,
> as that does not at all produce any sort of packages we like or want.
>
> Can you please explain how or why you are using these upstream scripts
> that do not produce neither Ubuntu nor Debian compliant kernel.deb
> packages that correctly integrate with our OS?


It is true that 'make bindeb-pkg' is unofficial in Ubuntu,
but it is useful to build a linux-image deb package incrementally.

I had a kernel micro-talk "Fast rebuilding kernel packages"
in Prague back in May.

Please see Page 11 of the slide PDF if you are interested.

KDEB_COMPRESS is available in jammy or later.

I locally apply this patch to focal variants.


Again, it is just an unofficial tip to work efficiently.
It is understandable if this is rejected,
but I thought it could be acceptable as it is just
one-liner backport from the mainline.




>
> >
> >  scripts/package/builddeb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> > index c4c580f547ef..b68aaeece7c9 100755
> > --- a/scripts/package/builddeb
> > +++ b/scripts/package/builddeb
> > @@ -43,7 +43,7 @@ create_package() {
> >
> >         # Create the package
> >         dpkg-gencontrol -p$pname -P"$pdir"
> > -       dpkg --build "$pdir" ..
> > +       dpkg-deb ${KDEB_COMPRESS:+-Z$KDEB_COMPRESS} --build "$pdir" ..
> >  }
> >
> >  version=$KERNELRELEASE
>
>
>
> --
> okurrr,
>
> Dimitri