NACK/Cmnt: [focal][PATCH] builddeb: allow selection of .deb compressor

Stefan Bader stefan.bader at canonical.com
Mon Jul 24 09:57:33 UTC 2023


On 24.07.23 10:23, Masahiro Yamada wrote:
> From: Michał Mirosław <mirq-linux at rere.qmqm.pl>
> 
> [ Upstream commit 1a7f0a34ea7d05d1ffcd32c9b1b4e07ac0687538 ]
> 
> Select deb compression using KDEB_COMPRESS make variable. This allows to
> use gzip compression for local or test builds, and that's way faster
> than now-default xz compression.
> 
> Signed-off-by: Michał Mirosław <mirq-linux at rere.qmqm.pl>
> Signed-off-by: Masahiro Yamada <masahiroy at kernel.org>
> Signed-off-by: Masahiro Yamada <masahiro.yamada at canonical.com>
> ---
> 
> This is not a bug-fix, but this is useful to speed-up 'make bindeb-pkg'.
> 
> 
>   scripts/package/builddeb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index c4c580f547ef..b68aaeece7c9 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -43,7 +43,7 @@ create_package() {
>   
>   	# Create the package
>   	dpkg-gencontrol -p$pname -P"$pdir"
> -	dpkg --build "$pdir" ..
> +	dpkg-deb ${KDEB_COMPRESS:+-Z$KDEB_COMPRESS} --build "$pdir" ..
>   }
>   
>   version=$KERNELRELEASE

Rejected for the following reasons:
- not following SRU policy 
(https://wiki.ubuntu.com/KernelTeam/KernelUpdates)
- also not sure Focal was already using xz

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230724/9318bbb0/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230724/9318bbb0/attachment-0001.sig>


More information about the kernel-team mailing list