NACK/Cmnt: [PATCH 0/5][SRU][M/L] Fix AMDGPU: the screen freeze with W7500

Tim Gardner tim.gardner at canonical.com
Wed Jul 19 13:02:50 UTC 2023


On 7/18/23 4:50 AM, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/2027957
> 
> [impact]
> While booting into OOBE, the screen freeze [AMD W7500 only]
> 
> [fix]
> AMDGPU would allocate pcie gen/lane dynamically after ASPM is enabled.
> Intel CPU may not support the dynamic lane/speed switching.
> 
> Solution is,
> - Detect Intel x86 systems that don't support dynamic switching
> - Override the input caps to maximum supported for that system
> - Force all PCIe levels to use the same settings, rather than try to configure each level differently.
> 
> [test cases]
> 1. boot with w7500
> 2. the screen doesn't freeze and can't find the error message in dmesg.
> "amdgpu: [drm] *ERROR* [CRTC:72:crtc-0] flip_done timed out"
> 
> [where the issue could happen]
> low, this could lead issue when setting higher speeds than supported.
> 
> [Misc]
> 1. jammy, amdgpu isn't loaded on this platform with 5.15-73-generic.
> 2. kinetic, amdgpu failed to probe the vga controller with 5.19-46-generic.
> 3. Passed cbd build against Mantic&Lunar.
> 4. For Lunar, need modification for function sienna_cichlid_update_pcie_parameters,
>     so provide another patch for e701156ccc6c) drm/amd: Align SMU11 SMU_MSG_OverridePcieParameters.
> 

'drmtip' really doesn't mean much in the context of a patch. If you're 
going to pull a patch from a relatively unknown source, then spell out 
the complete URL so the reviewer doesn't have to go hunting for the 
source repo. Since these patches have been merged into linux-next, then 
please resubmit a v2 with that noted in the 'cherry picked from' line.

-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list