NACK/Cmnt: [SRU] [J/L/Unstable] [PATCH 0/1] Fix unreliable ethernet cable detection on I219 NIC

[Stefan Bader]

On 19.07.23 07:58, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2028122
> 
> [Impact]
> Hotplugging RJ45 ethernet cable only works for one time because ACPI GPE
> wake doesn't working properly anymore.
> 
> [Fix]
> Always use PME poll to read PCI PME to know if there's wake event.
> 
> [Test]
> With the patch applied, ethernet cable can always be detected.
> 
> [Where problems could occur]
> PME poll mechanism periodically reads the PMCTRL register, so the power
> consumption can be slightly higher. The increase will be very low,
> probably won't be noticeable.
> 
> Kai-Heng Feng (1):
>    UBUNTU: SAUCE: e1000e: Use PME poll to circumvent unreliable ACPI wake
> 
>   drivers/net/ethernet/intel/e1000e/netdev.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 

Rejected for the following reasons:
I do not see sufficient reason to deviate from the SRU policy (that a 
patch has to be upstream) here.

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230719/f0d0b5ec/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230719/f0d0b5ec/attachment-0001.sig>