ACK: [SRU][F/J:linux-bluefield][PATCH v1 0/1] Bug fix for mlxbf-pmc

Tim Gardner tim.gardner at canonical.com
Tue Jan 31 17:04:27 UTC 2023


On 1/31/23 1:20 AM, Shravan Kumar Ramani wrote:
> BugLink: https://bugs.launchpad.net/bugs/2004235
> 
> SRU Justification:
> 
> [Impact]
> Currently, the driver uses fixed offsets for the control and data registers in the performance counter module. However, this is not correct since the module is not uniform in all HW blocks, and in this case, the llt_miss block is different from the rest.
> 
> [Fix]
> The number of counters present in each block is not fixed, and hence the offsets for the control and data registers should also be calculated accordingly.
> 
> [Test Case]
> Without the fix, writing 1 to the llt_miss "enable" file will not result in any of the counters incrementing. With the fix, the counters should increment even with the default event settings.
> 
> [Regression Potential]
> Can be considered minimal.
> 
> Shravan Kumar Ramani (1):
>    UBUNTU: SAUCE: mlxbf-pmc: Bug fix for BlueField-3 counter offsets
> 
>   drivers/platform/mellanox/mlxbf-pmc.c | 12 +++++++-----
>   drivers/platform/mellanox/mlxbf-pmc.h |  4 ++--
>   2 files changed, 9 insertions(+), 7 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list