[PATCH 1/1][SRU][U/OEM-6.1/OEM-6.0] UBUNTU: SAUCE: platform/x86: dell-wmi: Add a keymap for KEY_MUTE in type 0x0010 table

Andrea Righi andrea.righi at canonical.com
Mon Jan 23 06:49:27 UTC 2023


On Wed, Jan 18, 2023 at 02:40:21PM +0800, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/2003161 
> 
> Some platforms send the speaker-mute key from EC. dell-wmi can't
> recognize it.
> 
> Add a new keymap for KEY_MUTE in type 0x0010 table.
> 
> Ref: https://patchwork.kernel.org/project/platform-driver-x86/patch/20230117123436.200440-1-koba.ko@canonical.com/
> Signed-off-by: Koba Ko <koba.ko at canonical.com>
> ---
>  drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 0a259a27459f6..502783a7adb11 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -261,6 +261,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>  	{ KE_KEY,    0x57, { KEY_BRIGHTNESSDOWN } },
>  	{ KE_KEY,    0x58, { KEY_BRIGHTNESSUP } },
>  
> +	/*Speaker Mute*/

Just to be really picky, I'd prefer to see:

	/* Speaker Mute */

So it matches the proper coding style.

> +	{ KE_KEY, 0x109, { KEY_MUTE} },
> +
>  	/* Mic mute */
>  	{ KE_KEY, 0x150, { KEY_MICMUTE } },
>  

-Andrea



More information about the kernel-team mailing list