Bug#1029189: kpatch: FTBFS with shellcheck 0.9.0

[Andreas Beckmann]

Package: kpatch
Version: 0.9.7-2
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

Hi,

kpatch/experimental recently started to FTBFS:

   dh_auto_test
        make -j3 check
make[1]: Entering directory '/build/kpatch-0.9.7'
shellcheck kpatch/kpatch kpatch-build/kpatch-build kpatch-build/kpatch-cc

In kpatch/kpatch line 358:
                                break
                                ^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In kpatch-build/kpatch-build line 809:
                rpmbuild -D "_topdir $RPMTOPDIR" -bp --nodeps "--target=$(uname -m)" "$RPMTOPDIR"/SPECS/kernel$ALT.spec 2>&1 | logger ||
                                                                                                              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
                rpmbuild -D "_topdir $RPMTOPDIR" -bp --nodeps "--target=$(uname -m)" "$RPMTOPDIR"/SPECS/kernel"$ALT".spec 2>&1 | logger ||


In kpatch-build/kpatch-build line 1181:
                "$TOOLSDIR"/create-diff-object $CDO_FLAGS "orig/$i" "patched/$i" "$KOBJFILE_NAME" \
                                               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
                "$TOOLSDIR"/create-diff-object "$CDO_FLAGS" "orig/$i" "patched/$i" "$KOBJFILE_NAME" \


In kpatch-build/kpatch-build line 1244:
    MAKEVARS[$idx]=${MAKEVARS[$idx]/${KPATCH_CC_PREFIX}/}
             ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In kpatch-build/kpatch-build line 1263:
        "$TOOLSDIR"/create-klp-module $extra_flags "$TEMPDIR/patch/tmp.ko" "$TEMPDIR/patch/$MODNAME.ko" 2>&1 | logger 1
                                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        "$TOOLSDIR"/create-klp-module "$extra_flags" "$TEMPDIR/patch/tmp.ko" "$TEMPDIR/patch/$MODNAME.ko" 2>&1 | logger 1

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
  https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti...
make[1]: *** [Makefile:70: check] Error 1
make[1]: Leaving directory '/build/kpatch-0.9.7'
dh_auto_test: error: make -j3 check returned exit code 2


Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kpatch_0.9.7-2.log.gz
Type: application/gzip
Size: 11519 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230119/49ea6cac/attachment-0001.gz>