ACK/Cmnt: [SRU][PULL][Jammy:linux-intel-iotg] Request to include latest bug fixes and patches 2023-01-16

[Philip Cox]

Three minor comments.  The first is, the branch in LP has 8 other changes
for ADL-N in it.  141d42f1fc0dac7b81e66852c9146d810dfd8b75
to 674bc8c7358775de40f1ee7736b65ec415835515.  I did not review these
changes, I just reviewed the changes you listed below.

The other two comments are in-line, below...


On Mon, Jan 16, 2023 at 7:12 AM Jian Hui Lee <jianhui.lee at canonical.com>
wrote:


> Jian Hui Lee (1):
>       UBUNTU: SAUCE: (no-up) drm/i915: revert Alder Lake-S guc/huc setup
>

In this patch, can you please update the comment just above the code?  The
comment is no longer correct as it reads:

/* The parameter i915.enable_guc=2 is needed for EHL, ICL and ADL-S
   to enable HuC authentication but not explicitly required for ADL-P
   since HuC is default enabled. This check needs to be before the other
   conditions are checked because the gen11 gfx platforms would return
   out of the function and not get set.
 */






> Tony Luck (1):
>       x86/cpu: Add new Alderlake and Raptorlake CPU model numbers
>

Very minor nitpick, but maybe this one should be listed back ported rather
than cherry-picked, as it didn't add the #define for
INTEL_FAM6_RAPTORLAKE_P that the original commit did.  Feel free to ignore
this though. I just wanted to confirm that this was done on purpose, and
not something left out by mistake.

So, if you fix up the comment to the no-up patch, this is:
Acked-By: Philip Cox <philip.cox at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230117/c9c15ec2/attachment.html>