ACK/Cmnt: [Unstable/Lunar][PATCH 0/5] Misc debian rules cleanups

Tim Gardner tim.gardner at canonical.com
Wed Jan 11 13:13:42 UTC 2023


On 1/11/23 1:58 AM, Juerg Haefliger wrote:
> A couple of patches that clean up our build rules:
>   - Remove unused/obsolete env variables
>   - Clean up the 'skip check' feature and extend it to modules signature
>     checks
> 
> Juerg Haefliger (5):
>    UBUNTU: [Packaging] debian/rules: Drop AUTOBUILD
>    UBUNTU: [Packaging] debian/rules: Drop NOKERNLOG and PRINTSHAS env
>      variables
>    UBUNTU: [Packaging] debian/rules: Replace skip<foo> variables with
>      skip_checks
>    UBUNTU: [Packaging] checks/retpoline-check: Make 'skipretpoline'
>      argument optional
>    UBUNTU: [Packaging] checks/module-signature-check: Add 'skip_checks'
>      argument
> 
>   debian/rules                                 |  4 +--
>   debian/rules.d/0-common-vars.mk              | 34 ++------------------
>   debian/rules.d/1-maintainer.mk               |  9 ++----
>   debian/rules.d/2-binary-arch.mk              |  4 ---
>   debian/rules.d/3-binary-indep.mk             | 14 ++++----
>   debian/rules.d/4-checks.mk                   |  9 +++---
>   debian/scripts/checks/module-signature-check | 27 ++++++++++++----
>   debian/scripts/checks/retpoline-check        |  7 +++-
>   8 files changed, 44 insertions(+), 64 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

Seems reasonable. I kinda remember the AUTOBUILD stuff.
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list