APPLIED: [SRU][F:linux-bluefield][PATCH 0/2] Add support for CT accounting stats

[Bodong Wang]

Ack.
Apologies, Bartlomiej. Will fix and resubmit.

-----Original Message-----
From: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com> 
Sent: Monday, January 9, 2023 10:30 AM
To: Bodong Wang <bodong at nvidia.com>
Cc: kernel-team at lists.ubuntu.com; Vladimir Sokolovsky <vlad at nvidia.com>
Subject: Re: APPLIED: [SRU][F:linux-bluefield][PATCH 0/2] Add support for CT accounting stats

Hi Bodong,

I had to revert this patchset from focal:linux-bluefield/master-next for now as it causes following build failures:

    /build/focal/net/sched/act_ct.c: In function 'tcf_ct_flow_table_get':
    /build/focal/net/sched/act_ct.c:305:10: error:
'NF_FLOWTABLE_COUNTER' undeclared (first use in this function)
      305 |          NF_FLOWTABLE_COUNTER;
          |          ^~~~~~~~~~~~~~~~~~~~
    /build/focal/net/sched/act_ct.c:305:10: note: each undeclared identifier is reported only once for each function it appears in

    /build/focal/net/sched/act_ct.c: In function 'tcf_ct_flow_table_lookup':
    /build/focal/net/sched/act_ct.c:570:21: error:
'NF_FLOWTABLE_COUNTER' undeclared (first use in this function)
      570 |  if (nf_ft->flags & NF_FLOWTABLE_COUNTER)
          |                     ^~~~~~~~~~~~~~~~~~~~

    /build/focal/net/sched/act_ct.c:571:3: error: implicit declaration of functi on 'nf_ct_acct_update'; did you mean 'nf_ct_acct_enabled'? [-Werror=implicit-fun ction-declaration]

It seems that some preparatory patches are missing from the patchset.

--
Best regards,
Bartlomiej

On Thu, Jan 5, 2023 at 4:52 PM Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com> wrote:
>
> Applied to focal:linux-bluefield/master-next. Thanks.
>
> --
> Best regards,
> Bartlomiej
>
> On Tue, Dec 6, 2022 at 4:07 PM Bodong Wang <bodong at nvidia.com> wrote:
> >
> > Add CT accounting stats per flow for TC CT rules. This is only 
> > available when nf_conn_acct is enabled so it won’t affect performance when not enabled.
> >
> > First commit for SW, second commit of HW offloaded rules.
> >
> > Marcelo Ricardo Leitner (1):
> >   net/sched: act_ct: enable stats for HW offloaded entries
> >
> > wenxu (1):
> >   net/sched: act_ct: update nf_conn_acct for act_ct SW offload in
> >     flowtable
> >
> >  net/sched/act_ct.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >