ACK: [SRU J][PATCH] UBUNTU: SAUCE: Fix ftrace/Meta-selftests bashism check
Tim Gardner
tim.gardner at canonical.com
Tue Feb 28 13:40:01 UTC 2023
On 2/28/23 2:31 AM, Stefan Bader wrote:
> BugLink: https://bugs.launchpad.net/bugs/2006453
>
> Upstream commit a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for
> test_event_enable" introduces a test which is considered a bashism and
> as a result causes the Meta-selftests subtest to fail. Fix up the "=="
> to be "=" in order to avoid this.
>
> Fixes: a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for test_event_enable"
> Signed-off-by: Stefan Bader <stefan.bader at canonical.com>
> ---
>
> The same upstream stable fix now also causes the bashism check in Jammy
> to fail (was Focal before).
>
> -Stefan
>
> .../selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> index 27a68bbe778b..d9b812795077 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> @@ -42,7 +42,7 @@ test_event_enabled() {
>
> while [ $check_times -ne 0 ]; do
> e=`cat $EVENT_ENABLE`
> - if [ "$e" == $val ]; then
> + if [ "$e" = $val ]; then
> return 0
> fi
> sleep $SLEEP_TIME
Acked-by: Tim Gardner <tim.gardner at canonical.com>
--
-----------
Tim Gardner
Canonical, Inc
More information about the kernel-team
mailing list