NACK/Cmnt: [SRU][PULL REQUEST][J][PATCH V2 00/17][mpi3mr: Add management application interface(BSG) support

Thu Feb 23 08:30:26 UTC 2023

On 23.02.23 03:44, Michael Reed wrote:
> From: Michael Reed <Michael.Reed at canonical.com>
> 
> SRU Justification:

Using this NACK to point out a bunch of things which IMO would improve 
working together. First the subject, this is probably mostly my personal 
opinion only. But I would find something like "[SRU J][PULL REQUEST]" 
better readable than the split up form. Maybe to make things a little 
shorter it could be a "[PULL REQUEST v2 00/17]". Looking at it with a 
bigger font... I think the "...][mpi3mr:" should rather be a "...] mpi3mr:"

Next, putting the Launchpad bug report link for example here allows to 
quickly check on it without chasing the commits. In principle the bug 
report should be nominated to tell which series are targeted. Not sure 
this is possible for you.

> 
> [Impact]
> 
> Request to include below mpi3mr driver bug fix patches in Ubuntu 22.04.1(5.15 kernel). These patches got accepted by the upstream and please find the corresponding commit IDs as below:
> 
> f304d35e5995 scsi: mpi3mr: Update driver version to 8.0.0.69.0
> 7dbd0dd8cde3 scsi: mpi3mr: Add support for NVMe passthrough
> 986d6bad2103 scsi: mpi3mr: Expose adapter state to sysfs
> 43ca11005098 scsi: mpi3mr: Add support for PEL commands
> 506bc1a0d6ba scsi: mpi3mr: Add support for MPT commands
> f3de4706c1e0 scsi: mpi3mr: Move data structures/definitions from MPI headers to uapi header
> f5e6d5a34376 scsi: mpi3mr: Add support for driver commands
> 4268fa751365 scsi: mpi3mr: Add bsg device support
> 1fcbe4c49039 scsi: mpi3mr: Fix kernel-doc
> 4094981db7b6 scsi: mpi3mr: Rework mrioc->bsg_device model to fix warnings
> 9feb5c4c3f95 scsi: mpi3mr: Add target device related sysfs attributes
> e51e76edddb1 scsi: mpi3mr: Add shost related sysfs attributes
> bc7896d31a92 scsi: mpi3mr: Return error if dma_alloc_coherent() fails
> a25eafd13e5f scsi: mpi3mr: Fix a NULL vs IS_ERR() bug in mpi3mr_bsg_init()
> 256bd4f23d9c scsi: mpi3mr: Return I/Os to an unrecoverable HBA with DID_ERROR
> 2dd8389f96d6 scsi: mpi3mr: Hidden drives not removed during soft reset
> 1aa529d40025 scsi: mpi3mr: Increase I/O timeout value to 60s
> 
> [Test Plan]
> 
> 1. Install and boot kernel
> 2. Run basic I/O tests
> 
> [Where problems could occur]
> Moderate to low regression risk for the kernel as most changes are in the driver
> 
> [Other Info]
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/mpi3mr_bsg_support_3

I would have used 
https://git.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/log/?h=mpi3mr_bsg_support_3 
form for the "other info". Following that link makes it easy to check on 
the patches remotely.

> 
>   
> 
> The following changes since commit bba7582dd55251dceb8ecba87aeb829431c31f5d:
> 
>    scsi: mpi3mr: Add bsg device support (2023-02-22 16:11:09 -0600)

I am not sure this^ is correct. If git says "since", it usually means 
whatever comes after the mentioned commit. But I suspect you mean:

The following changes since commit  694cfca1f2939fd5a8a723a5f0466952cb435851

     UBUNTU: Upstream stable to v5.15.87

Could you please send a v3 with amends? Thanks.

Stefan

> 
> are available in the Git repository at:
> 
>    https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/mpi3mr_bsg_support_3
> 
> for you to fetch changes up to cd881d76543c55f0b0443524d96737bcfd29842b:
> 
>    scsi: mpi3mr: Fix kernel-doc (2023-02-22 18:55:41 -0600)
> 
> ----------------------------------------------------------------
> Dan Carpenter (2):
>        scsi: mpi3mr: Fix a NULL vs IS_ERR() bug in mpi3mr_bsg_init()
>        scsi: mpi3mr: Return error if dma_alloc_coherent() fails
> 
> Jiapeng Chong (1):
>        scsi: mpi3mr: Fix kernel-doc
> 
> Sreekanth Reddy (5):
>        scsi: mpi3mr: Increase I/O timeout value to 60s
>        scsi: mpi3mr: Hidden drives not removed during soft reset
>        scsi: mpi3mr: Return I/Os to an unrecoverable HBA with DID_ERROR
>        scsi: mpi3mr: Add shost related sysfs attributes
>        scsi: mpi3mr: Add target device related sysfs attributes
> 
> Sumit Saxena (8):
>        scsi: mpi3mr: Add support for driver commands
>        scsi: mpi3mr: Move data structures/definitions from MPI headers to uapi header
>        scsi: mpi3mr: Add support for MPT commands
>        scsi: mpi3mr: Add support for PEL commands
>        scsi: mpi3mr: Expose adapter state to sysfs
>        scsi: mpi3mr: Add support for NVMe passthrough
>        scsi: mpi3mr: Update driver version to 8.0.0.69.0
>        scsi: mpi3mr: Rework mrioc->bsg_device model to fix warnings
> 
>   drivers/scsi/mpi3mr/mpi/mpi30_init.h |   53 -
>   drivers/scsi/mpi3mr/mpi/mpi30_ioc.h  |   27 -
>   drivers/scsi/mpi3mr/mpi/mpi30_pci.h  |   31 +-
>   drivers/scsi/mpi3mr/mpi3mr.h         |  119 ++-
>   drivers/scsi/mpi3mr/mpi3mr_app.c     | 1807 +++++++++++++++++++++++++++++++++-
>   drivers/scsi/mpi3mr/mpi3mr_debug.h   |   37 +-
>   drivers/scsi/mpi3mr/mpi3mr_fw.c      |  335 ++++++-
>   drivers/scsi/mpi3mr/mpi3mr_os.c      |   68 +-
>   include/uapi/scsi/scsi_bsg_mpi3mr.h  |  582 +++++++++++
>   9 files changed, 2901 insertions(+), 158 deletions(-)
>   create mode 100644 include/uapi/scsi/scsi_bsg_mpi3mr.h
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230223/9db2bc78/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230223/9db2bc78/attachment-0001.sig>