APPLIED[K/F]/Cmnt: [SRU][F/K][PATCH 0/1] Enable selftests/net/fcnal-test.sh to run
Stefan Bader
stefan.bader at canonical.com
Fri Feb 17 10:27:03 UTC 2023
On 06.02.23 23:57, Luke Nowakowski-Krijger wrote:
> BugLink: https://bugs.launchpad.net/bugs/2006391
>
> [Impact]
>
> fcnal-test.sh in selftests/net gets skipped with 'nettest' command not found
> because its looking for the nettest binary in the path and not in the
> current directory where the binary is built and run from.
>
> There are also other tests in net that are skipped due to this binary
> not being found.
>
> [Fix]
>
> Add the current directory to the path and check again.
> This patch exists in Jammy through a stable update but hasn't made it to
> the other upstream-stable trees yet, but might as well get the patch in
> our other trees to enable this test to run.
>
> [Backport]
>
> For focal patch skip the pmtu.sh file as nettest is not run there and is
> not checked. Also minor context adjustments on return variable.
>
> [Potential regression]
>
> None. Just enabling the tests to run.
>
> [Tests]
>
> Verified tests are now not skipped and run.
>
> Daniel Díaz (1):
> selftests/net: Find nettest in current directory
>
> tools/testing/selftests/net/fcnal-test.sh | 11 +++++++----
> tools/testing/selftests/net/pmtu.sh | 10 ++++++----
> 2 files changed, 13 insertions(+), 8 deletions(-)
>
Applied to focal:linux/master-next. Kinetic was already done via
upstream set 2023-02-02. Added bug reference to that commit. Thanks.
-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230217/9d63d502/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230217/9d63d502/attachment-0001.sig>
More information about the kernel-team
mailing list